qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Sean Bruno <sbruno@freebsd.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"
Date: Sun, 12 Jun 2016 23:01:31 +0100	[thread overview]
Message-ID: <CAFEAcA8MXsWCug25+1V4A2dp5xSGp_jK9GBud35SgSAYLjrNsw@mail.gmail.com> (raw)
In-Reply-To: <575C4724.6030707@freebsd.org>

On 11 June 2016 at 18:15, Sean Bruno <sbruno@freebsd.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> - --quiet isn't available on FreeBSD and doesn't seem to be used in
> other places.  This fixes some non-fatal build errors on FreeBSD.  The
> use of "-s" over "--quiet" seems to be the preferred use in the Makefile.
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> - --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>                                 printf '""\n'; \
>                         fi; \
>                 fi) > $@.tmp)
> - -       $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> +       $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>
>  config-host.h: config-host.h-timestamp
>  config-host.h-timestamp: config-host.mak

Can you provide a Signed-off-by: for this patch, please?
We can't apply it without one.

(Providing it as a patch in the usual git format with
commit message would also be nice, but optional.)

thanks
-- PMM

      parent reply	other threads:[~2016-06-12 22:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-11 17:15 [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet" Sean Bruno
2016-06-11 20:42 ` Eric Blake
2016-06-12 22:01 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8MXsWCug25+1V4A2dp5xSGp_jK9GBud35SgSAYLjrNsw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sbruno@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).