From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Brian Cain <quic_bcain@quicinc.com>, qemu-devel@nongnu.org
Subject: Re: [Semihosting Tests PATCH v2 1/3] .editorconfig: add code conventions for tooling
Date: Fri, 31 May 2024 11:05:27 +0100 [thread overview]
Message-ID: <CAFEAcA8Mc+K=+ebMhRCmcAKDCsVq3hvmTWFOFWmpDOSYzzwhDg@mail.gmail.com> (raw)
In-Reply-To: <875xuucqee.fsf@draig.linaro.org>
On Fri, 31 May 2024 at 09:54, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Brian Cain <quic_bcain@quicinc.com> writes:
> > Related: would a .clang-format file also be useful? git-clang-format
> > can be used to apply formatting changes only on the code that's been
> > changed.
>
> As a pre-commit hook? Or via something like clangd?
I think last time somebody looked at clangd it wasn't quite
flexible enough to format code to QEMU's style preferences.
But that was some years ago, so I might be misremembering or
the situation might have changed.
In terms of project consensus, I think "here's tooling/config
you can use to follow our formatting preferences if you like"
is probably a better place to start than anything that is
an automatically-applied-by-default check.
(For the semihosting-tests I wouldn't bother, because they
get almost no contributions: 8 commits in the last 5 years.)
thanks
-- PMM
next prev parent reply other threads:[~2024-05-31 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 11:23 [Semihosting Tests PATCH v2 0/3] add SYS_GET_CMDLINE test Alex Bennée
2024-05-30 11:23 ` [Semihosting Tests PATCH v2 1/3] .editorconfig: add code conventions for tooling Alex Bennée
2024-05-30 15:22 ` Brian Cain
2024-05-31 8:54 ` Alex Bennée
2024-05-31 10:05 ` Peter Maydell [this message]
2024-05-30 11:23 ` [Semihosting Tests PATCH v2 2/3] update includes for bare metal compiling Alex Bennée
2024-05-30 11:23 ` [Semihosting Tests PATCH v2 3/3] add SYS_GET_CMDLINE test Alex Bennée
2024-05-30 14:31 ` [Semihosting Tests PATCH v2 0/3] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8Mc+K=+ebMhRCmcAKDCsVq3hvmTWFOFWmpDOSYzzwhDg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_bcain@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).