From: Peter Maydell <peter.maydell@linaro.org>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] ui/cocoa: Take refresh rate into account
Date: Mon, 20 Jun 2022 13:26:17 +0100 [thread overview]
Message-ID: <CAFEAcA8NS_fWpeKd2-c446ETJM2jRr7_bZ5ABOXr75A9TpnxSA@mail.gmail.com> (raw)
In-Reply-To: <20220614211909.94060-1-akihiko.odaki@gmail.com>
On Tue, 14 Jun 2022 at 22:19, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Hi; generally all commits should have some useful description
in the commit message body. In this case, it would be useful
to describe the motivation for the patch: is it fixing a bug?
What goes wrong with the current code?
thanks
-- PMM
prev parent reply other threads:[~2022-06-20 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 21:19 [PATCH] ui/cocoa: Take refresh rate into account Akihiko Odaki
2022-06-20 12:26 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8NS_fWpeKd2-c446ETJM2jRr7_bZ5ABOXr75A9TpnxSA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=akihiko.odaki@gmail.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).