From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHRVw-0003pk-RN for qemu-devel@nongnu.org; Tue, 30 Oct 2018 06:44:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHRVu-0006MX-OQ for qemu-devel@nongnu.org; Tue, 30 Oct 2018 06:44:48 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:42403) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHRVu-0006Iv-5K for qemu-devel@nongnu.org; Tue, 30 Oct 2018 06:44:46 -0400 Received: by mail-oi1-x243.google.com with SMTP id h23-v6so9922628oih.9 for ; Tue, 30 Oct 2018 03:44:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20181029151956.2164336-1-stefanb@linux.ibm.com> References: <20181029151956.2164336-1-stefanb@linux.ibm.com> From: Peter Maydell Date: Tue, 30 Oct 2018 10:44:20 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/10/29 v1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: QEMU Developers , Stefan Berger On 29 October 2018 at 15:19, Stefan Berger wrote: > From: Stefan Berger > > This pull request fixes a couple of TPM support related issues, > such as full initialization of a variable to quiet down valgrind, > a possible race in the TPM related test cases and marking test > cases as skipped if swtpm was not found in PATH. > > Stefan > > The following changes since commit a4d710251fa5aa9ec26de4626f11c78500195d= 12: > > Merge remote-tracking branch 'remotes/berrange/tags/qcrypto-next-pull-r= equest' into staging (2018-10-24 22:08:42 +0100) > > are available in the Git repository at: > > git://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-2018-10-29-1 > > for you to fetch changes up to f9da599490730cf0c3016f15225d7f1ee15bec75: > > tpm: Zero-init structure to avoid uninitialized variables in valgrind l= og (2018-10-27 10:33:18 -0400) > > ---------------------------------------------------------------- > Marc-Andr=C3=A9 Lureau (2): > tests/tpm: fix tpm_util_swtpm_has_tpm2() > tests/tpm: mark swtpm test as skipped instead of successful > > Stefan Berger (3): > docs: tpm: Mention implemented TPM CRB interface emulation and spec= s > MAINTAINERS: Change my email address to the new domain > tpm: Zero-init structure to avoid uninitialized variables in valgri= nd log Hi; this gives some test failures (all hosts): TEST: tests/tpm-crb-swtpm-test... (pid=3D305) /i386/tpm/crb-swtpm/test: FAIL GTester: last random seed: R02Sf628ca48da88252a6b95465fef3b855f /i386/tpm/crb-swtpm-migration/test: FAIL GTester: last random seed: R02Sf628ca48da88252a6b95465fef3b855f FAIL: tests/tpm-crb-swtpm-test TEST: tests/tpm-crb-test... (pid=3D311) /i386/tpm-crb/test: OK PASS: tests/tpm-crb-test TEST: tests/tpm-tis-swtpm-test... (pid=3D324) /i386/tpm/tis-swtpm/test: FAIL GTester: last random seed: R02Sca4f303959770d4ca9f8f12b784dba0d /i386/tpm/tis-swtpm-migration/test: FAIL GTester: last random seed: R02Sca4f303959770d4ca9f8f12b784dba0d FAIL: tests/tpm-tis-swtpm-test TEST: tests/tpm-tis-test... (pid=3D331) /i386/tpm-tis/test_check_localities: OK /i386/tpm-tis/test_check_access_reg: OK /i386/tpm-tis/test_check_access_reg_seize: OK /i386/tpm-tis/test_check_access_reg_release: OK /i386/tpm-tis/test_check_transmit: OK PASS: tests/tpm-tis-test and a compile failure on OSX: /Users/pm215/src/qemu-for-merges/hw/tpm/tpm_emulator.c:161:21: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] ptm_loc loc =3D { 0 }; ^ {} (what you want here is just "ptm_loc loc =3D {};" -- the "{ 0 }" syntax is the C standard one but not all compilers can handle it without warnings if the first member in the struct happens to be a substruct.) thanks -- PMM