From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2475C433DF for ; Fri, 3 Jul 2020 13:32:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B99FC20760 for ; Fri, 3 Jul 2020 13:32:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CJ6JzVVk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B99FC20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrLnR-0005xU-1y for qemu-devel@archiver.kernel.org; Fri, 03 Jul 2020 09:32:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrLmh-0005UV-DG for qemu-devel@nongnu.org; Fri, 03 Jul 2020 09:31:19 -0400 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:33989) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jrLmf-0003jx-Qa for qemu-devel@nongnu.org; Fri, 03 Jul 2020 09:31:19 -0400 Received: by mail-ot1-x341.google.com with SMTP id n5so26740615otj.1 for ; Fri, 03 Jul 2020 06:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fcs/DnolAyMQnVPDUbY6cHLRB6bDyuYOPPHgUE7BU18=; b=CJ6JzVVkuyaid0GNZ0fP4LclIVtzdZXOminDof7WfV1+aR5gwgebJ9mrC1kOhjgE32 +ii1cYVPeRfSzoc8C7K2jQ93fS+0l8jH4zhLTvABbRub86TmUskwWdRiyvLTdTwYeVna 1ZbDD/HNJGgBpX8q2yPFfid2OpX2sNCuADiktTlTsQdJuhMAfHENXEPyn4O/XhiyJSjw d33ov25aKfwXjgQwhz+72e9SIf4yJ6ejeqEaLVuvEOQlp52q0Vl6guxH44p0VMPl1+ts EC/oqDyr/hB0ASkvzD4NdyAw9+begmrl5mXAMcXVIy2eeCEhN/kYZwSueo6OaPDa0fbq et1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fcs/DnolAyMQnVPDUbY6cHLRB6bDyuYOPPHgUE7BU18=; b=Ikz4yKTCwjZbSLefrbA+4le2Lb/hFKXmiQLufM9JlCDj4z7MF4jh5th14fBJw/J41I MSVnYY+Uio155eyS3aWMxJ/Bdsz377k47h8b0SWdBhLWdErM5MiifpvEK0lIaq97ZGQr GMJyahe02EMf7j+cvR1YB3vOrIObUHmD/TBRNjHCV43ECnciE1Sa4bR/4LCB13vT4Fq3 NXS0AtvHcnTL/UAMzJPcJ05qNNmXkyFRBwueuXmdwMMyhd22ezgQiHKj/7DbBSCBG6yB XS26wIOXTyR2m/fWMkKC6dj0yAeNaF4H4j1YsLODsPNXe6S4JsyaNjYBM9idRQSNBmXm jeJg== X-Gm-Message-State: AOAM533vd7aole3d3qNvGUF0FumbKT96sFiep4TvAyrsTZc3S9zsQr0q 84ndl0ZMGw7v+dW8SRSwHCYsbJ124KTdgj/soJuYPw== X-Google-Smtp-Source: ABdhPJxF3TqPNvSEM/vdbRSfEKFWUgyoss38/QdRWv2uukhxCPelELdLjqT1PZTCb/EGi1/TeCwYmUfrVYj191nB3lM= X-Received: by 2002:a05:6830:10ce:: with SMTP id z14mr23210824oto.135.1593783076011; Fri, 03 Jul 2020 06:31:16 -0700 (PDT) MIME-Version: 1.0 References: <20200702175605.1987125-1-richard.henderson@linaro.org> In-Reply-To: <20200702175605.1987125-1-richard.henderson@linaro.org> From: Peter Maydell Date: Fri, 3 Jul 2020 14:31:05 +0100 Message-ID: Subject: Re: [PATCH] target/arm: Fix temp double-free in sve ldr/str To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::341; envelope-from=peter.maydell@linaro.org; helo=mail-ot1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 2 Jul 2020 at 18:56, Richard Henderson wrote: > > The temp that gets assigned to clean_addr has been allocated with > new_tmp_a64, which means that it will be freed at the end of the > instruction. Freeing it earlier leads to assertion failure. > > The loop creates a complication, in which we allocate a new local > temp, which does need freeing, and the final code path is shared > between the loop and non-loop. > > Fix this complication by adding new_tmp_a64_local so that the new > local temp is freed at the end, and can be treated exactly like > the non-loop path. > > Fixes: bba87d0a0f4 > Signed-off-by: Richard Henderson Applied to target-arm.next, thanks. -- PMM