From: Peter Maydell <peter.maydell@linaro.org>
To: Jason Wang <jasowang@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PULL V2 8/8] COLO-compare: Optimize tcp compare trace event
Date: Wed, 26 Apr 2017 16:55:58 +0100 [thread overview]
Message-ID: <CAFEAcA8OxPhzymdFqRd78zVmLPkqXptXWUKYpmYahmwykGwamw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA81uAqOZHiXBiQgrKO5Mziq47dRr=R_t5PLMV9qVxbSZw@mail.gmail.com>
On 26 April 2017 at 16:18, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 25 April 2017 at 12:26, Jason Wang <jasowang@redhat.com> wrote:
>> From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>
>> Optimize two trace events as one, adjust print format make
>> it easy to read. rename trace_colo_compare_pkt_info_src/dst
>> to trace_colo_compare_tcp_info.
>>
>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> Hi. This commit has broken building with the UST backend,
> because it is effectively reverting commit 2dfe5113b11,
> which split this trace line into two events because the
> UST backend has a limit on the number of arguments that
> a UST event can take.
>
> Could you revert it, please?
...actually it looks like it reverts cleanly on master, so
I'll just revert it directly.
thanks
-- PMM
next prev parent reply other threads:[~2017-04-26 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 11:26 [Qemu-devel] [PULL V2 0/8] Net patches Jason Wang
2017-04-25 11:26 ` [Qemu-devel] [PULL V2 1/8] colo-compare: Fix old packet check bug Jason Wang
2017-04-25 11:26 ` [Qemu-devel] [PULL V2 2/8] hw/net: add MII definitions Jason Wang
2017-04-25 11:26 ` [Qemu-devel] [PULL V2 3/8] net: add FTGMAC100 support Jason Wang
2017-04-25 11:26 ` [Qemu-devel] [PULL V2 4/8] net/ftgmac100: add a 'aspeed' property Jason Wang
2017-04-25 11:26 ` [Qemu-devel] [PULL V2 5/8] aspeed: add a FTGMAC100 nic Jason Wang
2017-04-25 11:26 ` [Qemu-devel] [PULL V2 6/8] slirp: add a fake NC-SI backend Jason Wang
2017-04-25 11:26 ` [Qemu-devel] [PULL V2 7/8] COLO-compare: Optimize tcp compare for option field Jason Wang
2017-04-25 11:26 ` [Qemu-devel] [PULL V2 8/8] COLO-compare: Optimize tcp compare trace event Jason Wang
2017-04-26 15:18 ` Peter Maydell
2017-04-26 15:55 ` Peter Maydell [this message]
2017-04-27 2:28 ` Jason Wang
2017-04-27 2:50 ` Zhang Chen
2017-04-25 13:48 ` [Qemu-devel] [PULL V2 0/8] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8OxPhzymdFqRd78zVmLPkqXptXWUKYpmYahmwykGwamw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).