From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Damien Hedde <damien.hedde@greensocs.com>,
Juan Quintela <quintela@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-4.1? 1/2] stellaris_input: Fix vmstate description of buttons field
Date: Fri, 26 Jul 2019 10:52:05 +0100 [thread overview]
Message-ID: <CAFEAcA8PROpFeKfxXFdVvVoZaus-MsX_EHGxw+yEUty_mnQdMQ@mail.gmail.com> (raw)
In-Reply-To: <c5a0799e-2ebe-5a79-915a-af52d471a589@redhat.com>
On Thu, 25 Jul 2019 at 18:40, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 7/25/19 7:02 PM, Dr. David Alan Gilbert wrote:
> > * Peter Maydell (peter.maydell@linaro.org) wrote:
> >> gamepad_state::buttons is a pointer to an array of structs,
> >> not an array of structs, so should be declared in the vmstate
> >> with VMSTATE_STRUCT_VARRAY_POINTER_INT32; otherwise we
> >> corrupt memory on incoming migration.
> >>
> >> We bump the vmstate version field as the easiest way to
> >> deal with the migration break, since migration wouldn't have
> >> worked reliably before anyway.
> >>
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > OK, it would be great to change num_buttons to uint32_t and make that a
> > UINT32 at some point; it's hard to press negative buttons.
>
> Since the version is incremented, now seems to be a good time.
...except this patch is for 4.1 and we've already done rc2,
so it's not really an ideal time to put in code cleanups...
thanks
-- PMM
next prev parent reply other threads:[~2019-07-26 9:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 16:37 [Qemu-devel] [PATCH for-4.1? 0/2] Typecheck VMSTATE VARRAY macros and fix bug found Peter Maydell
2019-07-25 16:37 ` [Qemu-devel] [PATCH for-4.1? 1/2] stellaris_input: Fix vmstate description of buttons field Peter Maydell
2019-07-25 17:02 ` Dr. David Alan Gilbert
2019-07-25 17:40 ` Philippe Mathieu-Daudé
2019-07-26 9:52 ` Peter Maydell [this message]
2019-07-26 9:59 ` Dr. David Alan Gilbert
2019-07-26 10:03 ` Peter Maydell
2019-07-25 17:59 ` Peter Maydell
2019-07-25 18:32 ` Dr. David Alan Gilbert
2019-07-26 8:25 ` Damien Hedde
2019-07-26 8:47 ` Peter Maydell
2019-07-25 16:37 ` [Qemu-devel] [PATCH for-4.1? 2/2] vmstate.h: Type check VMSTATE_STRUCT_VARRAY macros Peter Maydell
2019-07-25 17:27 ` Dr. David Alan Gilbert
2019-07-25 17:57 ` Peter Maydell
2019-07-25 18:00 ` Dr. David Alan Gilbert
2019-07-26 9:24 ` Peter Maydell
2019-07-26 9:32 ` Dr. David Alan Gilbert
2019-07-26 9:33 ` Peter Maydell
2019-07-26 9:34 ` Dr. David Alan Gilbert
2019-07-26 9:12 ` Damien Hedde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8PROpFeKfxXFdVvVoZaus-MsX_EHGxw+yEUty_mnQdMQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=damien.hedde@greensocs.com \
--cc=dgilbert@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).