From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWOEE-00068B-9n for qemu-devel@nongnu.org; Thu, 18 Feb 2016 08:02:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWOED-000123-Ea for qemu-devel@nongnu.org; Thu, 18 Feb 2016 08:02:42 -0500 Received: from mail-vk0-x231.google.com ([2607:f8b0:400c:c05::231]:33506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWOED-00011g-3N for qemu-devel@nongnu.org; Thu, 18 Feb 2016 08:02:41 -0500 Received: by mail-vk0-x231.google.com with SMTP id k196so43697736vka.0 for ; Thu, 18 Feb 2016 05:02:40 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1455621027-13927-3-git-send-email-zxq_yx_007@163.com> References: <1455621027-13927-1-git-send-email-zxq_yx_007@163.com> <1455621027-13927-3-git-send-email-zxq_yx_007@163.com> From: Peter Maydell Date: Thu, 18 Feb 2016 13:02:20 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 12/16] hw/timer: QOM'ify pl031 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: xiaoqiang zhao Cc: Evgeny Voevodin , Mark Cave-Ayland , QEMU Developers , Michael Walle , qemu-arm , "Edgar E. Iglesias" , Guan Xuetao , =?UTF-8?Q?Andreas_F=C3=A4rber?= On 16 February 2016 at 11:10, xiaoqiang zhao wrote: > assign pl031_init to pl031_info.instance_init and drop the > SysBusDeviceClass::init > > Reviewed-by: Peter Maydell > Signed-off-by: xiaoqiang zhao I didn't review this patch! Please be more careful about only applying reviewed-by: tags to the correct patches when you're sending out new versions. (You seem to have got this wrong for some of the others in this series too.) thanks -- PMM