From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: QEMU Developer <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Fix build for less common build directories names
Date: Thu, 13 Oct 2016 19:36:07 +0100 [thread overview]
Message-ID: <CAFEAcA8QADee1et4jSGP26i8atRy2KG29wMab_nieisNvCicEQ@mail.gmail.com> (raw)
In-Reply-To: <1476383370-30650-1-git-send-email-sw@weilnetz.de>
On 13 October 2016 at 19:29, Stefan Weil <sw@weilnetz.de> wrote:
> scripts/tracetool generates a C preprocessor macro from the name of the
> build directory. Any characters which are possible in a directory name
> but not allowed in a macro name must be substituted, otherwise builds
> will fail.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> I had problems with a build directory of the form "host,variant".
> Is this fix needed for stable, too?
Why does it need to care about the build directory name at all?
Ideally builds should be entirely deterministically reproducible
whatever the path to the source or build directory names is...
thanks
-- PMM
next prev parent reply other threads:[~2016-10-13 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 18:29 [Qemu-devel] [PATCH] Fix build for less common build directories names Stefan Weil
2016-10-13 18:36 ` Peter Maydell [this message]
2016-10-14 9:53 ` Stefan Hajnoczi
2016-10-14 10:17 ` Paolo Bonzini
2016-10-14 10:01 ` Stefan Hajnoczi
2016-10-14 20:05 ` Stefan Weil
2016-10-16 13:36 ` Stefan Hajnoczi
2016-10-16 14:31 ` Michael Tokarev
2016-10-16 19:04 ` Peter Maydell
2016-10-17 4:43 ` Stefan Weil
2016-10-28 14:57 ` Michael Tokarev
2016-10-28 15:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8QADee1et4jSGP26i8atRy2KG29wMab_nieisNvCicEQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).