From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bukrm-0003eo-QF for qemu-devel@nongnu.org; Thu, 13 Oct 2016 14:36:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bukrk-0006PC-UT for qemu-devel@nongnu.org; Thu, 13 Oct 2016 14:36:29 -0400 Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:35133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bukrk-0006Of-Aj for qemu-devel@nongnu.org; Thu, 13 Oct 2016 14:36:28 -0400 Received: by mail-vk0-x234.google.com with SMTP id q126so35950809vkd.2 for ; Thu, 13 Oct 2016 11:36:28 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1476383370-30650-1-git-send-email-sw@weilnetz.de> References: <1476383370-30650-1-git-send-email-sw@weilnetz.de> From: Peter Maydell Date: Thu, 13 Oct 2016 19:36:07 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] Fix build for less common build directories names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developer , QEMU Trivial , Stefan Hajnoczi On 13 October 2016 at 19:29, Stefan Weil wrote: > scripts/tracetool generates a C preprocessor macro from the name of the > build directory. Any characters which are possible in a directory name > but not allowed in a macro name must be substituted, otherwise builds > will fail. > > Signed-off-by: Stefan Weil > --- > > I had problems with a build directory of the form "host,variant". > Is this fix needed for stable, too? Why does it need to care about the build directory name at all? Ideally builds should be entirely deterministically reproducible whatever the path to the source or build directory names is... thanks -- PMM