From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Giuseppe Musacchio <thatlemon@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
QEMU Developers <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures
Date: Thu, 5 Nov 2020 23:36:56 +0000 [thread overview]
Message-ID: <CAFEAcA8R45sv+EbeqOBdkbT7buzvFbugBdro1MxfTKw2NrD4oQ@mail.gmail.com> (raw)
In-Reply-To: <6bdc7371-58a8-a4a8-a948-8e7fce921fdb@linaro.org>
On Thu, 5 Nov 2020 at 22:15, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 11/5/20 1:23 PM, Peter Maydell wrote:
> > +} __attribute__((aligned(16)));
>
> Hmph, 96 uses of the attribute directly, 20 uses of QEMU_ALIGNED. I suppose we
> should just remove the wrapper...
Oops, I forget about that. We're better at adhering to use
of QEMU_SENTINEL and QEMU_NORETURN, at least. And a fair
chunk of those 96 are in code-that's-not-ours like the
headers imported from Linux or the pc-bios/s390-ccw code.
I'm in two minds here -- the wrappers look less clunky than
the __attribute__ syntax, but on the other hand "there is
only one way this can be written" results in less inconsistency
than "there are two ways".
thanks
-- PMM
next prev parent reply other threads:[~2020-11-05 23:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 21:23 [PATCH for-5.2 0/3] linux-user: fix various sparc64 guest bugs Peter Maydell
2020-11-05 21:23 ` [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures Peter Maydell
2020-11-05 22:15 ` Richard Henderson
2020-11-05 23:36 ` Peter Maydell [this message]
2020-11-10 6:53 ` Laurent Vivier
2020-11-10 9:02 ` LemonBoy
2020-11-10 9:41 ` Laurent Vivier
2020-11-05 21:23 ` [PATCH for-5.2 2/3] linux-user/sparc: Correct set/get_context handling of fp and i7 Peter Maydell
2020-11-05 22:22 ` Richard Henderson
2020-11-10 6:53 ` Laurent Vivier
2020-11-05 21:23 ` [PATCH for-5.2 3/3] linux-user/sparc: Don't zero high half of PC, NPC, PSR in sigreturn Peter Maydell
2020-11-05 22:23 ` Richard Henderson
2020-11-10 6:55 ` Laurent Vivier
2020-11-10 12:56 ` [PATCH for-5.2 0/3] linux-user: fix various sparc64 guest bugs Mark Cave-Ayland
2020-11-10 13:01 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8R45sv+EbeqOBdkbT7buzvFbugBdro1MxfTKw2NrD4oQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thatlemon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).