From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tczop-0004n8-2x for qemu-devel@nongnu.org; Mon, 26 Nov 2012 09:38:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tczof-0004g0-JQ for qemu-devel@nongnu.org; Mon, 26 Nov 2012 09:37:54 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:42099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tczof-0004fT-DP for qemu-devel@nongnu.org; Mon, 26 Nov 2012 09:37:45 -0500 Received: by mail-ie0-f173.google.com with SMTP id e13so5995152iej.4 for ; Mon, 26 Nov 2012 06:37:44 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87k3t8qvrg.fsf@codemonkey.ws> References: <1353595852-30776-1-git-send-email-fred.konrad@greensocs.com> <1353595852-30776-2-git-send-email-fred.konrad@greensocs.com> <87k3t8qvrg.fsf@codemonkey.ws> Date: Mon, 26 Nov 2012 14:37:44 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, afaerber@suse.de, fred.konrad@greensocs.com On 26 November 2012 14:33, Anthony Liguori wrote: > VirtioBusInfo is not a great name. This is a proxy class that allows > for a device to implement the virtio bus interface. > > This could be done as an interface but since nothing else uses > interfaces, I'm okay with something like this. But the first argument > ought to be an opaque for all methods. We have at least one user of Interface in the tree IIRC. I'd much rather we did this the right way -- the only reason it's the way Fred has coded it is that there's no obvious body of code in the tree to copy, so we're thrashing around a bit. If you tell us what the correct set of structs/classes/ interfaces/etc is then we can implement it :-) -- PMM