From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] Makefile: add dependency on scripts/create_config
Date: Tue, 7 Jun 2016 13:09:10 +0100 [thread overview]
Message-ID: <CAFEAcA8RiVooeu8HSkvLFScAv0kuGnx3QVwaXSHUkiULPaqmHQ@mail.gmail.com> (raw)
In-Reply-To: <0e015abb-becc-081a-4965-0f53bd14eb74@redhat.com>
On 7 June 2016 at 13:05, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 07/06/2016 13:58, Peter Maydell wrote:
>> Does it work to add the dependency on the RHS of the pattern rule
>> instead, like:
>>
>> config-%.h-timestamp: config-%.mak $(SRC_PATH)/scripts/create_config
>> $(call quiet-command, sh $(SRC_PATH)/scripts/create_config <
>> $< > $@, " GEN $(TARGET_DIR)config-$*.h")
>
> Yes, that works too.
Cool -- I think it's a bit clearer to add the dependency
in the same place where the rule text invoking the script is.
thanks
-- PMM
next prev parent reply other threads:[~2016-06-07 12:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 11:48 [Qemu-devel] [PATCH 0/3] Makefile: add dependencies on scripts Paolo Bonzini
2016-06-07 11:48 ` [Qemu-devel] [PATCH 1/3] Makefile: add dependency on scripts/create_config Paolo Bonzini
2016-06-07 11:58 ` Peter Maydell
2016-06-07 12:05 ` Paolo Bonzini
2016-06-07 12:09 ` Peter Maydell [this message]
2016-06-07 12:11 ` Paolo Bonzini
2016-06-07 11:48 ` [Qemu-devel] [PATCH 2/3] Makefile: add dependency on scripts/make_device_config.sh Paolo Bonzini
2016-06-07 11:59 ` Peter Maydell
2016-06-07 11:48 ` [Qemu-devel] [PATCH 3/3] Makefile: add dependency on scripts/hxtool Paolo Bonzini
2016-06-07 12:00 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8RiVooeu8HSkvLFScAv0kuGnx3QVwaXSHUkiULPaqmHQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).