From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bAFp5-0007b5-CQ
	for qemu-devel@nongnu.org; Tue, 07 Jun 2016 08:09:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bAFp4-0000ve-9J
	for qemu-devel@nongnu.org; Tue, 07 Jun 2016 08:09:31 -0400
Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:35814)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bAFp4-0000vY-58
	for qemu-devel@nongnu.org; Tue, 07 Jun 2016 08:09:30 -0400
Received: by mail-vk0-x22f.google.com with SMTP id d127so239461046vkh.2
	for <qemu-devel@nongnu.org>; Tue, 07 Jun 2016 05:09:30 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <0e015abb-becc-081a-4965-0f53bd14eb74@redhat.com>
References: <1465300083-72463-1-git-send-email-pbonzini@redhat.com>
	<1465300083-72463-2-git-send-email-pbonzini@redhat.com>
	<CAFEAcA80q_-r8iQ19YWNkBdGZGEYrr5BmR98fSGDZq+tX2j1AQ@mail.gmail.com>
	<0e015abb-becc-081a-4965-0f53bd14eb74@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 7 Jun 2016 13:09:10 +0100
Message-ID: <CAFEAcA8RiVooeu8HSkvLFScAv0kuGnx3QVwaXSHUkiULPaqmHQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/3] Makefile: add dependency on
 scripts/create_config
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 7 June 2016 at 13:05, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 07/06/2016 13:58, Peter Maydell wrote:
>> Does it work to add the dependency on the RHS of the pattern rule
>> instead, like:
>>
>> config-%.h-timestamp: config-%.mak $(SRC_PATH)/scripts/create_config
>>         $(call quiet-command, sh $(SRC_PATH)/scripts/create_config <
>> $< > $@, "  GEN   $(TARGET_DIR)config-$*.h")
>
> Yes, that works too.

Cool -- I think it's a bit clearer to add the dependency
in the same place where the rule text invoking the script is.

thanks
-- PMM