From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYZff-0004H5-Qb for qemu-devel@nongnu.org; Thu, 28 Jun 2018 12:21:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYZff-0007ot-0Z for qemu-devel@nongnu.org; Thu, 28 Jun 2018 12:21:23 -0400 Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]:34554) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYZfe-0007nW-S1 for qemu-devel@nongnu.org; Thu, 28 Jun 2018 12:21:22 -0400 Received: by mail-oi0-x242.google.com with SMTP id c2-v6so5747909oic.1 for ; Thu, 28 Jun 2018 09:21:22 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1529699547-17044-6-git-send-email-alindsay@codeaurora.org> References: <1529699547-17044-1-git-send-email-alindsay@codeaurora.org> <1529699547-17044-6-git-send-email-alindsay@codeaurora.org> From: Peter Maydell Date: Thu, 28 Jun 2018 17:21:01 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v5 05/13] target/arm: Remove redundant DIV detection for KVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aaron Lindsay Cc: qemu-arm , Alistair Francis , Wei Huang , Peter Crosthwaite , QEMU Developers , Michael Spradling , Digant Desai , Aaron Lindsay On 22 June 2018 at 21:32, Aaron Lindsay wrote: > KVM implies V7VE, which implies ARM_DIV and THUMB_DIV. The conditional > detection here is therefore unnecessary. Because V7VE is already > unconditionally specified for all KVM hosts, ARM_DIV and THUMB_DIV are > already indirectly specified and do not need to be included here at all. > > Signed-off-by: Aaron Lindsay > --- Reviewed-by: Peter Maydell thanks -- PMM