From: Peter Maydell <peter.maydell@linaro.org>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: lsoaresp@redhat.com, marcandre.lureau@gmail.com,
qemu-devel@nongnu.org, peterx@redhat.com,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v2 3/3] migration: Perform vmsd structure check during tests
Date: Wed, 2 Feb 2022 13:52:34 +0000 [thread overview]
Message-ID: <CAFEAcA8SEed=crJr1_gpRCQwAkTn+bgAqfbUEGch9JZo8EAnvA@mail.gmail.com> (raw)
In-Reply-To: <Yfprvld4Y/GoJbhh@work-vm>
On Wed, 2 Feb 2022 at 11:32, Dr. David Alan Gilbert <dgilbert@redhat.com> wrote:
> Because in my local world I did the changes to libslirp; I wanted to
> make sure qemu people were happy with the changes before proposing them
> to libslirp.
>
> Which I've just done:
>
> https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/112
Does QEMU's own vmstate handling code see the libslirp vmstate
structures ? Looking at the code it seems to me like QEMU's
migration code only interacts with slirp via the
slirp_state_save() and slirp_state_load() functions.
Internally those work with some use of a vmstate structure,
but the code that iterates over field arrays in those is
all inside slirp itself (in src/slirp/vmstate.c if you're
looking at the in-tree copy).
So maybe I'm missing something but I'm not sure there really
is a dependency on the libslirp change here...
-- PMM
prev parent reply other threads:[~2022-02-02 14:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 19:44 [PATCH v2 0/3] vmsd checks Dr. David Alan Gilbert (git)
2022-01-13 19:44 ` [PATCH v2 1/3] ppc: Fix vmstate_pbr403 subsection name Dr. David Alan Gilbert (git)
2022-01-13 20:43 ` Peter Maydell
2022-01-17 9:53 ` Dr. David Alan Gilbert
2022-01-26 20:51 ` Juan Quintela
2022-01-13 19:44 ` [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST Dr. David Alan Gilbert (git)
2022-01-13 20:41 ` Peter Maydell
2022-01-14 11:32 ` Philippe Mathieu-Daudé via
2022-01-14 15:35 ` Philippe Mathieu-Daudé via
2022-01-13 19:44 ` [PATCH v2 3/3] migration: Perform vmsd structure check during tests Dr. David Alan Gilbert (git)
2022-01-13 20:42 ` Peter Maydell
2022-01-26 20:53 ` Juan Quintela
2022-01-27 15:49 ` Dr. David Alan Gilbert
2022-01-31 9:00 ` Juan Quintela
2022-02-02 11:32 ` Dr. David Alan Gilbert
2022-02-02 13:09 ` Juan Quintela
2022-02-02 13:52 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8SEed=crJr1_gpRCQwAkTn+bgAqfbUEGch9JZo8EAnvA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).