From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] nbd/server: Silence gcc false positive
Date: Fri, 22 Jun 2018 13:59:15 +0100 [thread overview]
Message-ID: <CAFEAcA8SdUhXXyi4kcgQCodzxHFYyeMZVRrSB1==ddSLBDh6+A@mail.gmail.com> (raw)
In-Reply-To: <20180622125814.345274-1-eblake@redhat.com>
On 22 June 2018 at 13:58, Eric Blake <eblake@redhat.com> wrote:
> The code has a while() loop that always initialized 'end', and
> the loop always executes at least once (as evidenced by the assert()
> just prior to the loop). But some versions of gcc still complain
> that 'end' is used uninitialized, so silence them.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> Peter, do you want to apply this directly as a build fix, or shall
> I submit a pull request?
I'll just apply it directly.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2018-06-22 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 12:58 [Qemu-devel] [PATCH] nbd/server: Silence gcc false positive Eric Blake
2018-06-22 12:59 ` Peter Maydell [this message]
2018-06-22 14:12 ` Peter Maydell
2018-06-22 15:26 ` Eric Blake
2018-06-22 16:31 ` no-reply
2018-06-22 16:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8SdUhXXyi4kcgQCodzxHFYyeMZVRrSB1==ddSLBDh6+A@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).