From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <sw@weilnetz.de>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] libvixl: Fix typo in comment
Date: Mon, 24 Feb 2014 12:19:25 +0000 [thread overview]
Message-ID: <CAFEAcA8T=Z-Kauhh+tiHCPV_ikApy-mqTrgMHvz2=3Cg2m-Ncg@mail.gmail.com> (raw)
In-Reply-To: <1393012441-4112-1-git-send-email-sw@weilnetz.de>
On 21 February 2014 19:54, Stefan Weil <sw@weilnetz.de> wrote:
> * substract -> subtract
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> disas/libvixl/a64/constants-a64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
It seems like a bad idea to make more changes than
necessary to a component we will probably be updating
with new upstream releases. We've made fixes where we
need to so the code will build, but fixing typos in
comments doesn't really seem worthwhile to me.
thanks
-- PMM
prev parent reply other threads:[~2014-02-24 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 19:54 [Qemu-devel] [PATCH] libvixl: Fix typo in comment Stefan Weil
2014-02-24 12:19 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8T=Z-Kauhh+tiHCPV_ikApy-mqTrgMHvz2=3Cg2m-Ncg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).