* [Qemu-devel] [PATCH] libvixl: Fix typo in comment
@ 2014-02-21 19:54 Stefan Weil
2014-02-24 12:19 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2014-02-21 19:54 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
* substract -> subtract
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
disas/libvixl/a64/constants-a64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/libvixl/a64/constants-a64.h b/disas/libvixl/a64/constants-a64.h
index 2e0336d..3d7b3c1 100644
--- a/disas/libvixl/a64/constants-a64.h
+++ b/disas/libvixl/a64/constants-a64.h
@@ -71,7 +71,7 @@ V_(ImmDPShift, 15, 10, Bits) \
V_(ImmAddSub, 21, 10, Bits) \
V_(ShiftAddSub, 23, 22, Bits) \
\
-/* Add/substract extend */ \
+/* Add/subtract extend */ \
V_(ImmExtendShift, 12, 10, Bits) \
V_(ExtendMode, 15, 13, Bits) \
\
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] libvixl: Fix typo in comment
2014-02-21 19:54 [Qemu-devel] [PATCH] libvixl: Fix typo in comment Stefan Weil
@ 2014-02-24 12:19 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2014-02-24 12:19 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Trivial, QEMU Developers
On 21 February 2014 19:54, Stefan Weil <sw@weilnetz.de> wrote:
> * substract -> subtract
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> disas/libvixl/a64/constants-a64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
It seems like a bad idea to make more changes than
necessary to a component we will probably be updating
with new upstream releases. We've made fixes where we
need to so the code will build, but fixing typos in
comments doesn't really seem worthwhile to me.
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-24 12:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 19:54 [Qemu-devel] [PATCH] libvixl: Fix typo in comment Stefan Weil
2014-02-24 12:19 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).