From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] coverity_scan: switch to vpath build
Date: Tue, 22 Sep 2020 14:31:58 +0100 [thread overview]
Message-ID: <CAFEAcA8Tssk+9YgsE5MMnar8fq+XjuVjo_u-YW5BnZA57oOt_Q@mail.gmail.com> (raw)
In-Reply-To: <044dc012-1203-e3a8-0758-b0fcb2d932a4@redhat.com>
On Tue, 22 Sep 2020 at 14:27, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 9/22/20 3:18 PM, Peter Maydell wrote:
> > This comment at the top of the script:
> >
> > # This script assumes that you're running it from a QEMU source
> > # tree, and that tree is a fresh clean one, because we do an in-tree
> > # build. (This is necessary so that the filenames that the Coverity
> > # Scan server sees are relative paths that match up with the component
> > # regular expressions it uses; an out-of-tree build won't work for this.)
> >
> > is now out of date and needs rephrasing.
>
> Or we can keep it as it, since commit dedad027205
> ("configure: add support for pseudo-"in source tree" builds")
> already create a 'build/' directory.
No, because even with the pseudo-in-tree build the paths will
no longer be the relative ones that the real pre-meson in-tree
build had, so the comment is no longer correct.
thanks
-- PMM
next prev parent reply other threads:[~2020-09-22 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 13:08 [PATCH] coverity_scan: switch to vpath build Paolo Bonzini
2020-09-22 13:12 ` Philippe Mathieu-Daudé
2020-09-22 13:18 ` Peter Maydell
2020-09-22 13:27 ` Philippe Mathieu-Daudé
2020-09-22 13:31 ` Peter Maydell [this message]
2020-09-22 16:35 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2020-10-29 17:22 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8Tssk+9YgsE5MMnar8fq+XjuVjo_u-YW5BnZA57oOt_Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).