From: Peter Maydell <peter.maydell@linaro.org>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, berrange@redhat.com,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] audio/dbus: make "dbus" the default backend when using -display dbus
Date: Mon, 3 Nov 2025 10:04:29 +0000 [thread overview]
Message-ID: <CAFEAcA8U=dRuAvSf5n=tNbNNk039YLXo9UBRe_Vis689x7JaFg@mail.gmail.com> (raw)
In-Reply-To: <20251103100158.1148552-1-marcandre.lureau@redhat.com>
On Mon, 3 Nov 2025 at 10:02, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Set "using_dbus_display" during early_dbus_init(), so that we can try to
> create the "dbus" audio backend by default from audio_prio_list.
>
> This makes dbus audio work by default when using an audio device,
> without having to setup and wire up the -audiodev manually.
>
> The added FIXME is addressed in the coming up cleanup series.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> audio/audio.c | 3 +++
> audio/dbusaudio.c | 8 +++++++-
> ui/dbus.c | 17 +++++++++++++---
> 3 files changed, 23 insertions(+), 5 deletions(-)
Shouldn't we be documenting this somewhere? Having -display
affect the audio is a bit non-obvious : generally we prefer
to have options be orthogonal and the user to specify what
they want rather than trying for "do what I mean" behaviour.
-- PMM
prev parent reply other threads:[~2025-11-03 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 10:01 [PATCH] audio/dbus: make "dbus" the default backend when using -display dbus marcandre.lureau
2025-11-03 10:04 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8U=dRuAvSf5n=tNbNNk039YLXo9UBRe_Vis689x7JaFg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).