From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Chris Howard <cvz185@web.de>
Subject: Re: [PATCH] target/arm: Use field names for accessing DBGWCRn
Date: Thu, 28 Apr 2022 13:40:38 +0100 [thread overview]
Message-ID: <CAFEAcA8UGvLKPj=5AgcfLp6C7TfSJRjR7ar9TOesHixj2VmBMw@mail.gmail.com> (raw)
In-Reply-To: <20220427051926.295223-1-richard.henderson@linaro.org>
On Wed, 27 Apr 2022 at 06:22, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> While defining these names, use the correct field width of 5 not 4 for
> DBGWCR.MASK. This typo prevented setting a watchpoint larger than 32k.
>
> Reported-by: Chris Howard <cvz185@web.de>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/internals.h | 12 ++++++++++++
> target/arm/debug_helper.c | 10 +++++-----
> target/arm/helper.c | 8 ++++----
> target/arm/kvm64.c | 14 +++++++-------
> 4 files changed, 28 insertions(+), 16 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
prev parent reply other threads:[~2022-04-28 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 5:19 [PATCH] target/arm: Use field names for accessing DBGWCRn Richard Henderson
2022-04-27 10:37 ` Alex Bennée
2022-04-28 12:40 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8UGvLKPj=5AgcfLp6C7TfSJRjR7ar9TOesHixj2VmBMw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=cvz185@web.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).