Re: [Qemu-devel] [PULL 0/9] tricore patches

[Peter Maydell <peter.maydell@linaro.org>]

On 26 January 2015 at 20:03, Bastian Koppelmann
<kbastian@mail.uni-paderborn.de> wrote:
> The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2:
>
>   qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +0000)
>
> are available in the git repository at:
>
>   https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore20150126-2
>
> for you to fetch changes up to 24c3bf03341ada63a0728f2bdfd2b7c226ad958e:
>
>   target-tricore: Add instructions of RRR opcode format (2015-01-26 19:56:46 +0000)
>
> ----------------------------------------------------------------
> tricore bugfixes and RR1, RR2, RRPW and RRR insn
>
> ----------------------------------------------------------------

Looks like this would introduce a new clang warning:

/home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23:
warning: equality
      comparison with extraneous parentheses [-Wparentheses-equality]
        if ((up_shift == 32)) {
             ~~~~~~~~~^~~~~
/home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23:
note: remove extraneous
      parentheses around the comparison to silence this warning
        if ((up_shift == 32)) {
            ~         ^    ~
/home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23:
note: use '=' to turn
      this equality comparison into an assignment
        if ((up_shift == 32)) {
                      ^~
                      =

We've nearly managed to eradicate all our clang warnings so I
don't want to add more at this point -- could you fix this
and resend the pullreq, please?

thanks
-- PMM