From: Peter Maydell <peter.maydell@linaro.org>
To: Programmingkid <programmingkidx@gmail.com>
Cc: qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu
Date: Mon, 11 May 2015 15:33:13 +0100 [thread overview]
Message-ID: <CAFEAcA8Uebju2ZK8e0a4wuPAChuU4m7ZoUdoUdH8muOVhdjNmg@mail.gmail.com> (raw)
In-Reply-To: <EAD5C449-042D-4486-9793-5E5D6C4733A6@gmail.com>
On 11 May 2015 at 15:29, Programmingkid <programmingkidx@gmail.com> wrote:
>
> On May 11, 2015, at 9:20 AM, Peter Maydell wrote:
>> Can't we just create a menu with an item for every console,
>> and set its menu text to the result of qemu_console_get_label() ?
>> I don't see why we need to special case these four and only
>> display those.
> We *could* do it that way, but it wouldn't look pretty. Instead of having these menu items:
>
> VGA, Monitor, Serial, Parallel
>
> We would have these menu items:
>
> VGA
> compat_monitor0
> serial0
> parallel0
>
> They look very anti-pretty.
They're the menu entries we have in the GTK UI. If you want
pretty names then you should fix this in the common code
so that any UI that wants to display pretty names can do
that. Having the OSX UI do things differently is not a
good idea.
-- PMM
next prev parent reply other threads:[~2015-05-11 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 0:32 [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu Programmingkid
2015-05-11 13:20 ` Peter Maydell
2015-05-11 14:29 ` Programmingkid
2015-05-11 14:33 ` Peter Maydell [this message]
2015-05-11 14:38 ` Programmingkid
2015-05-11 14:49 ` Peter Maydell
2015-05-12 10:33 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8Uebju2ZK8e0a4wuPAChuU4m7ZoUdoUdH8muOVhdjNmg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).