From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrom4-0007xe-Dl for qemu-devel@nongnu.org; Mon, 11 May 2015 10:33:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yroly-0000iy-VP for qemu-devel@nongnu.org; Mon, 11 May 2015 10:33:40 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:32954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yroly-0000ir-Qs for qemu-devel@nongnu.org; Mon, 11 May 2015 10:33:34 -0400 Received: by igbpi8 with SMTP id pi8so73161927igb.0 for ; Mon, 11 May 2015 07:33:34 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Peter Maydell Date: Mon, 11 May 2015 15:33:13 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: qemu-devel qemu-devel On 11 May 2015 at 15:29, Programmingkid wrote: > > On May 11, 2015, at 9:20 AM, Peter Maydell wrote: >> Can't we just create a menu with an item for every console, >> and set its menu text to the result of qemu_console_get_label() ? >> I don't see why we need to special case these four and only >> display those. > We *could* do it that way, but it wouldn't look pretty. Instead of having these menu items: > > VGA, Monitor, Serial, Parallel > > We would have these menu items: > > VGA > compat_monitor0 > serial0 > parallel0 > > They look very anti-pretty. They're the menu entries we have in the GTK UI. If you want pretty names then you should fix this in the common code so that any UI that wants to display pretty names can do that. Having the OSX UI do things differently is not a good idea. -- PMM