From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Alistair Francis <alistair.francis@xilinx.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v6 03/13] sdhci: refactor same sysbus/pci properties into a common one
Date: Fri, 12 Jan 2018 17:05:30 +0000 [thread overview]
Message-ID: <CAFEAcA8UvqmtzxcQrDWF24OQsBek0s2uYPOsoCs5YqH80MpXnw@mail.gmail.com> (raw)
In-Reply-To: <20180111193021.17466-4-f4bug@amsat.org>
On 11 January 2018 at 19:30, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Now both sysbus/pci classes inherit of the 'pending-insert-quirk' property,
> which is a HCI dependent property (regardless if accessed through a MMIO
> sysbus or a PCI bus).
> So far only the BCM implementation has to use it.
>
> Add sysbus/pci/sdbus comments to have clearer code blocks separation.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
I'm not sure about this patch, because it means that we now have
no mechanism for having a property which exists on the sysbus
device but not on the PCI device (and as per my comments on the
last patch in this set, we do need to be able to do that).
thanks
-- PMM
next prev parent reply other threads:[~2018-01-12 17:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 19:30 [Qemu-devel] [PATCH v6 00/13] SDHCI: housekeeping Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 01/13] sdhci: clean up includes Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 02/13] sdhci: remove dead code Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 03/13] sdhci: refactor same sysbus/pci properties into a common one Philippe Mathieu-Daudé
2018-01-12 17:05 ` Peter Maydell [this message]
2018-01-12 17:20 ` Philippe Mathieu-Daudé
2018-01-12 18:45 ` Philippe Mathieu-Daudé
2018-01-12 18:52 ` Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 04/13] sdhci: refactor common sysbus/pci class_init() into sdhci_common_class_init() Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 05/13] sdhci: refactor common sysbus/pci realize() into sdhci_common_realize() Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 06/13] sdhci: refactor common sysbus/pci unrealize() into sdhci_common_unrealize() Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 07/13] sdhci: use qemu_log_mask(UNIMP) instead of fprintf() Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 08/13] sdhci: convert the DPRINT() calls into trace events Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 09/13] sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h" Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 10/13] sdhci: rename the SDHC_CAPAB register Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 11/13] sdhci: fix CAPAB/MAXCURR registers, both are 64bit and read-only Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 12/13] sdhci: Implement write method of ACMD12ERRSTS register Philippe Mathieu-Daudé
2018-01-11 19:30 ` [Qemu-devel] [PATCH v6 13/13] sdhci: add a "dma" property Philippe Mathieu-Daudé
2018-01-12 17:03 ` Peter Maydell
2018-01-12 17:19 ` Philippe Mathieu-Daudé
2018-01-11 21:11 ` [Qemu-devel] [PATCH v6 00/13] SDHCI: housekeeping Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8UvqmtzxcQrDWF24OQsBek0s2uYPOsoCs5YqH80MpXnw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair.francis@xilinx.com \
--cc=andrew.smirnov@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).