From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE75CC001DB for ; Fri, 4 Aug 2023 12:56:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRuLw-0006N0-KG; Fri, 04 Aug 2023 08:56:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRuLv-0006Df-As for qemu-devel@nongnu.org; Fri, 04 Aug 2023 08:56:23 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRuLt-00054I-KL for qemu-devel@nongnu.org; Fri, 04 Aug 2023 08:56:23 -0400 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-52256241c66so4467518a12.1 for ; Fri, 04 Aug 2023 05:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691153780; x=1691758580; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6U61MjXLtP3NkaKUtU+YZZFVPUnYtCxQmJilaj4LaMY=; b=QvJf6e+bhz2+08a0ab3k0FkaW42OOU/NAlioA7pOC23XN18RIueCEZ/DjPQx9muHbN ZQmK545Bc/My5TMcy1Tk82i8t75QNqv0ZxaPZ9e1tfXVM4Y0pdaSeYc4CDqdoo762VGe eLy+TIVLf+wGKe+mhpckImFhGEv1MUYy0YLMGLE1wOUNA/L26elHPD+3t84KMDVKwhjQ nekT+Of0Aa0i34yE0l4MwDLaD0IHTdik2t8agz75RVm9hPeIJLymUAZgpFMTF+TfUzFh 0ZCKxgZxcVNAez940o6m7yQwGJdvsQEF6RIjsZrRnhJvqhQ1jJCyacFgLHyhlIygyalq B7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691153780; x=1691758580; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6U61MjXLtP3NkaKUtU+YZZFVPUnYtCxQmJilaj4LaMY=; b=ihUhMmugDWEpgmhVJm9AhYjLL+zIiHbewtdLkjBJKBocNPqqOiDq3zv+AqHQgq39mR p+RIBQfFub4W7bUJb9ST7ThiQcFSCo/OHR166ZE19JtIEq53xcGVqM4CEUcmeaH6YYrP g2N8ugwbiNfc89kdmhtXldVRrcumcnBXmKGclEpTUO4uHNLxXQX1Bhvsz4O004a6nM7O zChV+bDEVVzI8Gj9srhgIgPzYIUBaVwHnK7XpKoU8W/nXQJggE8Dsge1clMvYF4QYuRL 5S+v5iNAw/OytQduoDX4cGH6FWu2tddsi975Zqd2tO4oROCNn/r+NOsHxPaqUpcFPAAW C/Jg== X-Gm-Message-State: AOJu0YxeyvNIHiDXYEF8EgIwecYRruSLibu73k3hbqNYU2xMsSugKoio lXr+JcfGFDMLFKQ3q6uCNKnf7IVFhSMRPrrz8ZD22je3BdCx5hbq X-Google-Smtp-Source: AGHT+IGMrXo928/Z9rV10bMaaTraWaMvFDDl9+0ZB1TTaRFjL6H/apNY+1odYIhpdOLXUbKLfCa7dZIDPSvMPWthOxQ= X-Received: by 2002:a05:6402:3507:b0:522:ddeb:cdcb with SMTP id b7-20020a056402350700b00522ddebcdcbmr1996213edd.18.1691153780047; Fri, 04 Aug 2023 05:56:20 -0700 (PDT) MIME-Version: 1.0 References: <20230726132512.149618-1-sergey.kambalin@auriga.com> <20230726132512.149618-14-sergey.kambalin@auriga.com> In-Reply-To: <20230726132512.149618-14-sergey.kambalin@auriga.com> From: Peter Maydell Date: Fri, 4 Aug 2023 13:56:09 +0100 Message-ID: Subject: Re: [PATCH 13/44] Add memory region for BCM2837 RPiVid ASB To: Sergey Kambalin Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Sergey Kambalin Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 26 Jul 2023 at 14:34, Sergey Kambalin wrote: I notice that all these patches have no commit message except for the subject line. Generally we prefer commits to have more description of what they're doing and why than that, although for simple patches it doesn't need to be very much. > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_peripherals.c | 3 +++ > include/hw/arm/bcm2838_peripherals.h | 3 ++- > include/hw/arm/raspi_platform.h | 1 + > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c > index 0c5e716853..f689e16535 100644 > --- a/hw/arm/bcm2838_peripherals.c > +++ b/hw/arm/bcm2838_peripherals.c > @@ -182,6 +182,9 @@ static void bcm2838_peripherals_realize(DeviceState *dev, Error **errp) > sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->gpio), 0)); > > object_property_add_alias(OBJECT(s), "sd-bus", OBJECT(&s->gpio), "sd-bus"); > + > + /* BCM2838 RPiVid ASB must be mapped to prevent kernel crash */ > + create_unimp(s_base, &s->asb, "bcm2838-asb", RPI4B_ASB_OFFSET, 0x24); > } > > static void bcm2838_peripherals_class_init(ObjectClass *oc, void *data) > diff --git a/include/hw/arm/bcm2838_peripherals.h b/include/hw/arm/bcm2838_peripherals.h > index aba38a18f0..ebed11dd40 100644 > --- a/include/hw/arm/bcm2838_peripherals.h > +++ b/include/hw/arm/bcm2838_peripherals.h > @@ -66,12 +66,13 @@ struct BCM2838PeripheralState { > MemoryRegion mphi_mr_alias; > > SDHCIState emmc2; > - UnimplementedDeviceState clkisp; Rebase/patch split artefact ? This got added in an earlier patch, so rather than adding and then removing it, better to not add the line at all. > BCM2838GpioState gpio; > > OrIRQState mmc_irq_orgate; > OrIRQState dma_7_8_irq_orgate; > OrIRQState dma_9_10_irq_orgate; > + > + UnimplementedDeviceState asb; Otherwise Reviewed-by: Peter Maydell thanks -- PMM