From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text
Date: Fri, 18 Dec 2015 13:01:07 +0000 [thread overview]
Message-ID: <CAFEAcA8VxYbYYWHcevhOVndWnTegAWvKMnmd-HR+-p04ws8bGw@mail.gmail.com> (raw)
In-Reply-To: <87wpsbex5u.fsf@blackfin.pond.sub.org>
On 18 December 2015 at 12:52, Markus Armbruster <armbru@redhat.com> wrote:
> Cao jin <caoj.fnst@cn.fujitsu.com> writes:
>
>> There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it
>> is missed.
> I suspect there are more instances of the same problem.
> Not sure how interested we are in consistent use of these macros...
In a lot of cases we'd need to find somewhere appropriate to put the
TYPE_* macro which might well mean creating a new header file just
for the purpose. That seems like overkill...
thanks
-- PMM
next prev parent reply other threads:[~2015-12-18 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 8:52 [Qemu-devel] [PATCH v2] Use macro instead of plain text Cao jin
2015-12-18 12:52 ` Markus Armbruster
2015-12-18 13:01 ` Peter Maydell [this message]
2015-12-20 10:16 ` Cao jin
2015-12-20 10:09 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8VxYbYYWHcevhOVndWnTegAWvKMnmd-HR+-p04ws8bGw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).