From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9uf2-0001gv-Kn for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:01:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9uf1-0008Uv-NV for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:01:28 -0500 Received: from mail-vk0-x231.google.com ([2607:f8b0:400c:c05::231]:34316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9uf1-0008Up-It for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:01:27 -0500 Received: by mail-vk0-x231.google.com with SMTP id j66so64764912vkg.1 for ; Fri, 18 Dec 2015 05:01:27 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87wpsbex5u.fsf@blackfin.pond.sub.org> References: <1450428770-18215-1-git-send-email-caoj.fnst@cn.fujitsu.com> <87wpsbex5u.fsf@blackfin.pond.sub.org> From: Peter Maydell Date: Fri, 18 Dec 2015 13:01:07 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Eduardo Habkost , "Michael S. Tsirkin" , QEMU Trivial , QEMU Developers , Cao jin , Paolo Bonzini , Richard Henderson On 18 December 2015 at 12:52, Markus Armbruster wrote: > Cao jin writes: > >> There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it >> is missed. > I suspect there are more instances of the same problem. > Not sure how interested we are in consistent use of these macros... In a lot of cases we'd need to find somewhere appropriate to put the TYPE_* macro which might well mean creating a new header file just for the purpose. That seems like overkill... thanks -- PMM