From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>,
Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Huacai Chen <chenhuacai@kernel.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 1/2] hw/intc: Add Loongson Inter Processor Interrupt controller
Date: Thu, 14 Jan 2021 15:21:30 +0000 [thread overview]
Message-ID: <CAFEAcA8W2gOprJJ7r6bKgsG2r5a6_w5anTO77omuYTHqJcSSMQ@mail.gmail.com> (raw)
In-Reply-To: <8d1047c5-9049-6b4e-edb7-386de792f4cb@amsat.org>
On Thu, 14 Jan 2021 at 15:15, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> A SysBusDevice should use DeviceReset. qemu_register_reset()
> should be restricted to non-SysBusDevice devices. If there
> are no other comments on this series, I can fix this when
> applying.
The device also seems to be missing a vmstate struct.
thanks
-- PMM
next prev parent reply other threads:[~2021-01-14 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 1:31 [PATCH v2 0/2] loongson3_virt TCG SMP support Jiaxun Yang
2021-01-14 1:31 ` [PATCH v2 1/2] hw/intc: Add Loongson Inter Processor Interrupt controller Jiaxun Yang
2021-01-14 15:08 ` Philippe Mathieu-Daudé
2021-01-14 15:21 ` Peter Maydell [this message]
2021-01-14 1:31 ` [PATCH v2 2/2] hw/mips/loongson3_virt: Add TCG SMP support Jiaxun Yang
2021-01-17 22:46 ` Philippe Mathieu-Daudé
2021-01-17 22:58 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8W2gOprJJ7r6bKgsG2r5a6_w5anTO77omuYTHqJcSSMQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=chenhuacai@kernel.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).