qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Jason Wang <jasowang@redhat.com>
Cc: Sven Schnelle <svens@stackframe.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] net: add tulip (dec21143) driver
Date: Tue, 22 Oct 2019 13:02:47 +0100	[thread overview]
Message-ID: <CAFEAcA8W=ePk6vqErnXGwCXqOJ9ATz-00caAHDcCA-pgJ8Womw@mail.gmail.com> (raw)
In-Reply-To: <f6cf2c88-ae77-2998-2b38-4716fe86f081@redhat.com>

On Tue, 22 Oct 2019 at 04:30, Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2019/10/20 上午1:38, Sven Schnelle wrote:
> > This adds the basic functionality to emulate a Tulip NIC.
> >
> > Implemented are:
> >
> > - RX and TX functionality
> > - Perfect Frame Filtering
> > - Big/Little Endian descriptor support
> > - 93C46 EEPROM support
> > - LXT970 PHY
> >
> > Not implemented, mostly because i had no OS using these functions:
> >
> > - Imperfect frame filtering
> > - General Purpose Timer
> > - Transmit automatic polling
> > - Boot ROM support
> > - SIA interface
> > - Big/Little Endian data buffer conversion
> >
> > Successfully tested with the following Operating Systems:
> >
> > - MSDOS with Microsoft Network Client 3.0 and DEC ODI drivers
> > - HPPA Linux
> > - Windows XP
> > - HP-UX
> >
> > Signed-off-by: Sven Schnelle<svens@stackframe.org>
> > ---
>
>
> Applied.

Hi Jason; I just sent some code review comments on this patch
so you might want to hold off on applying it for now.

thanks
-- PMM


  reply	other threads:[~2019-10-22 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19 17:38 [PATCH] net: add tulip (dec21143) driver Sven Schnelle
2019-10-22  3:29 ` Jason Wang
2019-10-22 12:02   ` Peter Maydell [this message]
2019-10-23  3:32     ` Jason Wang
2019-10-22 12:02 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8W=ePk6vqErnXGwCXqOJ9ATz-00caAHDcCA-pgJ8Womw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).