From: Peter Maydell <peter.maydell@linaro.org>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Add qemu-doc.txt to distclean and dependencies
Date: Tue, 24 Jan 2017 15:38:34 +0000 [thread overview]
Message-ID: <CAFEAcA8WKghLcJZLSkPoipGPPsaeqZpDwpPQv2iO4rhss2H=ew@mail.gmail.com> (raw)
In-Reply-To: <CAJ+F1CJBkM9tJdi7thJSzMY_tqUFy=O-WALtVmYA2h2QYryJPQ@mail.gmail.com>
On 24 January 2017 at 14:16, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> Hi
>
> On Tue, Jan 24, 2017 at 6:05 PM Peter Maydell <peter.maydell@linaro.org>
> wrote:
>>
>> When qemu-doc.txt was added as a new output format in
>> commit f8bab10b4c3f, it was not added to either the
>> list of files to remove in distclean or to the dependency
>> line that forces qemu-options.texi to be built before
>> attempting to build qemu-doc.*.
>>
>> In particular, the missing dependency meant that on
>> some platforms (notably OSX hosts) we would try to
>> build qemu-doc.txt before qemu-options.texi had been
>> fully written out, and then makeinfo would complain
>> about missing cross-reference targets.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
>
>
> good catch, sorry about the regression
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Thanks; applied to master as a buildfix.
-- PMM
prev parent reply other threads:[~2017-01-24 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 14:02 [Qemu-devel] [PATCH] Makefile: Add qemu-doc.txt to distclean and dependencies Peter Maydell
2017-01-24 14:16 ` Marc-André Lureau
2017-01-24 15:38 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8WKghLcJZLSkPoipGPPsaeqZpDwpPQv2iO4rhss2H=ew@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).