qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"William Tsai" <williamtsai1111@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH 0/1] qom: fix setting of qdev array properties
Date: Tue, 5 Sep 2023 10:35:14 +0100	[thread overview]
Message-ID: <CAFEAcA8WyXaqpMsZbYW5hHa8EyqQTjZu=zW8WM6Ca0QpNKLCGA@mail.gmail.com> (raw)
In-Reply-To: <ZPbt0io6He9mE2SB@redhat.com>

On Tue, 5 Sept 2023 at 09:59, Kevin Wolf <kwolf@redhat.com> wrote:
>
> Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben:
> > By the time of the 8.2.0 release, it will have been 2 years and 6
> > releases since we accidentally broke setting of array properties
> > for user creatable devices:
> >
> >   https://gitlab.com/qemu-project/qemu/-/issues/1090
>
> Oh, nice!
>
> Well, maybe that sounds a bit wrong, but the syntax that was broken was
> problematic and more of a hack, and after two years there is clearly no
> need to bring the exact same syntax back now.
>
> So I'd suggest we bring the funcionality back, but with proper QAPI
> lists instead of len-foo/foo[*].

I don't object, as long as somebody is proposing to actually
do this work (eg, in this release cycle), rather than merely
suggest the idea as a reason why we should continue to leave
this device's configurability broken...

thanks
-- PMM


  reply	other threads:[~2023-09-05  9:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 16:25 [PATCH 0/1] qom: fix setting of qdev array properties Daniel P. Berrangé
2023-09-04 16:25 ` [PATCH 1/1] qom: fix setting of " Daniel P. Berrangé
2023-09-05  8:58 ` [PATCH 0/1] qom: fix setting of qdev " Kevin Wolf
2023-09-05  9:35   ` Peter Maydell [this message]
2023-09-07  9:33   ` Markus Armbruster
2023-09-07  9:35     ` Peter Maydell
2023-09-07 10:06       ` Daniel P. Berrangé
2023-09-08  9:25       ` Kevin Wolf
2023-09-08  9:27         ` Daniel P. Berrangé
2023-09-08 12:16           ` Kevin Wolf
2023-09-08 12:19             ` Daniel P. Berrangé
2023-09-08  9:53         ` Peter Maydell
2023-09-08 12:22           ` Kevin Wolf
2023-09-08 12:52             ` Peter Maydell
2023-09-07 12:59     ` Kevin Wolf
2023-09-07 14:16       ` Markus Armbruster
2023-09-07  9:45 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8WyXaqpMsZbYW5hHa8EyqQTjZu=zW8WM6Ca0QpNKLCGA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=williamtsai1111@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).