qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Francois Revol <revol@free.fr>,
	"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file
Date: Mon, 14 Aug 2017 15:25:04 +0100	[thread overview]
Message-ID: <CAFEAcA8X2K+d7FuAw0YW3Z9g7RbjfTYT0z-fsnM-X8QUOm9ROw@mail.gmail.com> (raw)
In-Reply-To: <alpine.BSF.2.21.1708141316200.10227@zero.eik.bme.hu>

On 14 August 2017 at 12:18, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> On Mon, 14 Aug 2017, Paolo Bonzini wrote:
>> Can you move it to hw/i2c while you're at it?

> I could if that's the preferred way but I've left it in hw/ppc because this
> is not a generic device but specific to PPC SoCs and it was easier
> to work with files in one dir than scattered through the tree. Should I
> still move it to hw/i2c?

Yeah, when you have a device that's both "type X" and
"architecture Y" you can't put it both in hw/Y and hw/X,
and the choice we've made is that hw/$ARCH is for:
 * board models
 * SoC container objects which just instantiate other devices
and "leaf" devices go under the relevand hw/$CATEGORY
(which may be hw/misc if nothing more appropriate exists).
It's a little bit arbitrary, but it follows a similar practice
in the Linux kernel source tree layout.

thanks
-- PMM

  parent reply	other threads:[~2017-08-14 14:25 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-13 17:04 [Qemu-devel] [RFC PATCH 00/12] Sam460ex emulation BALATON Zoltan
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 03/12] ohci: Allow sysbus version to be used as a companion BALATON Zoltan
2017-08-15  4:13   ` David Gibson
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 09/12] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs BALATON Zoltan
2017-08-18  1:53   ` David Gibson
2017-08-18 11:07     ` François Revol
2017-08-18 12:15       ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2017-08-18 12:18       ` [Qemu-devel] " David Gibson
2017-08-18  9:30   ` [Qemu-devel] [Qemu-ppc] " luigi burdo
2017-08-18 11:20     ` François Revol
2017-08-18 13:03       ` BALATON Zoltan
2017-08-18 12:34     ` BALATON Zoltan
2017-08-18 19:43       ` luigi burdo
2017-08-18 20:52         ` François Revol
2017-08-19 10:03         ` BALATON Zoltan
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 07/12] ppc4xx_i2c: Implement basic I2C functions BALATON Zoltan
2017-08-18  1:42   ` David Gibson
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file BALATON Zoltan
2017-08-14  4:41   ` David Gibson
2017-08-14  9:00   ` Paolo Bonzini
2017-08-14 11:18     ` BALATON Zoltan
2017-08-14 14:19       ` Paolo Bonzini
2017-08-14 14:25       ` Peter Maydell [this message]
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 11/12] ppc4xx: Export ECB and PLB emulation BALATON Zoltan
2017-08-14  4:44   ` David Gibson
2017-08-14 11:06     ` BALATON Zoltan
2017-08-18  6:11       ` David Gibson
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 10/12] ppc: Add 460EX embedded CPU BALATON Zoltan
2017-08-14  4:40   ` David Gibson
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 04/12] ehci: Add ppc4xx-ehci for the USB 2.0 controller in embedded PPC SoCs BALATON Zoltan
2017-08-14  4:36   ` David Gibson
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board BALATON Zoltan
2017-08-18  6:10   ` David Gibson
2017-08-18 11:24     ` François Revol
2017-08-18 12:46     ` BALATON Zoltan
2017-08-22  2:35       ` David Gibson
2017-08-22 11:18         ` BALATON Zoltan
2017-08-23  0:35           ` David Gibson
2017-08-23  0:48             ` BALATON Zoltan
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 06/12] ppc4xx_i2c: QOMify BALATON Zoltan
2017-08-15  4:17   ` David Gibson
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 02/12] ppc4xx: Make MAL emulation more generic BALATON Zoltan
2017-08-15  4:11   ` David Gibson
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 08/12] hw/ide: Emulate SiI3112 SATA controller BALATON Zoltan
2017-08-14  4:42   ` David Gibson
2017-08-14 11:16     ` BALATON Zoltan
2017-08-15 11:40       ` David Gibson
2017-08-13 17:04 ` [Qemu-devel] [RFC PATCH 01/12] ppc4xx: Move MAL from ppc405_uc to ppc4xx_devs BALATON Zoltan
2017-08-14  4:37   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8X2K+d7FuAw0YW3Z9g7RbjfTYT0z-fsnM-X8QUOm9ROw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=agraf@suse.de \
    --cc=balaton@eik.bme.hu \
    --cc=david@gibson.dropbear.id.au \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=revol@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).