From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhGJ5-0004QP-Ly for qemu-devel@nongnu.org; Mon, 14 Aug 2017 10:25:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhGJ4-00032Z-RX for qemu-devel@nongnu.org; Mon, 14 Aug 2017 10:25:27 -0400 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:36496) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhGJ4-0002zW-M3 for qemu-devel@nongnu.org; Mon, 14 Aug 2017 10:25:26 -0400 Received: by mail-wm0-x22b.google.com with SMTP id t201so38710254wmt.1 for ; Mon, 14 Aug 2017 07:25:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <0d150f9d-bca2-7bbd-aecf-584d65646c23@redhat.com> From: Peter Maydell Date: Mon, 14 Aug 2017 15:25:04 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: Paolo Bonzini , Francois Revol , "qemu-ppc@nongnu.org" , QEMU Developers , David Gibson , Alexander Graf On 14 August 2017 at 12:18, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, Paolo Bonzini wrote: >> Can you move it to hw/i2c while you're at it? > I could if that's the preferred way but I've left it in hw/ppc because this > is not a generic device but specific to PPC SoCs and it was easier > to work with files in one dir than scattered through the tree. Should I > still move it to hw/i2c? Yeah, when you have a device that's both "type X" and "architecture Y" you can't put it both in hw/Y and hw/X, and the choice we've made is that hw/$ARCH is for: * board models * SoC container objects which just instantiate other devices and "leaf" devices go under the relevand hw/$CATEGORY (which may be hw/misc if nothing more appropriate exists). It's a little bit arbitrary, but it follows a similar practice in the Linux kernel source tree layout. thanks -- PMM