From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Randy Yates <yates@ieee.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] elf_ops: Don't try to g_mapped_file_unref(NULL)
Date: Thu, 23 Apr 2020 21:47:38 +0100 [thread overview]
Message-ID: <CAFEAcA8XBsfZvxsjXVFbcHwcBYx3ohyfhntAKTTEWKcCw9xSCg@mail.gmail.com> (raw)
In-Reply-To: <d9e2c1cf-30e5-a889-3e87-eed6480610ab@redhat.com>
On Thu, 23 Apr 2020 at 21:25, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 4/23/20 10:20 PM, Peter Maydell wrote:
> > This will fix the assertion; for the specific case of the generic
> > loader it will then fall back from "guess this is an ELF file" to
> > "maybe it's a uImage or a hex file" and eventually to "just load as
> > a raw data file".
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks; as a side note "let me just load this as a raw data file"
is not a very user-friendly way to report issues with the ELF
file like "seems to be truncated" or "has no program headers".
Not sure what to do about that...
thanks
-- PMM
next prev parent reply other threads:[~2020-04-23 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 20:20 [PATCH] elf_ops: Don't try to g_mapped_file_unref(NULL) Peter Maydell
2020-04-23 20:24 ` Philippe Mathieu-Daudé
2020-04-23 20:47 ` Peter Maydell [this message]
2020-04-24 8:02 ` Stefano Garzarella
2020-05-04 9:46 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8XBsfZvxsjXVFbcHwcBYx3ohyfhntAKTTEWKcCw9xSCg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=yates@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).