From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Xyn8h-0002Un-Jk
	for qemu-devel@nongnu.org; Wed, 10 Dec 2014 14:41:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Xyn8c-0004TH-Kr
	for qemu-devel@nongnu.org; Wed, 10 Dec 2014 14:41:35 -0500
Received: from mail-lb0-f177.google.com ([209.85.217.177]:51726)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Xyn8c-0004TB-DT
	for qemu-devel@nongnu.org; Wed, 10 Dec 2014 14:41:30 -0500
Received: by mail-lb0-f177.google.com with SMTP id b6so2858640lbj.22
	for <qemu-devel@nongnu.org>; Wed, 10 Dec 2014 11:41:29 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.1.10.1412100136320.19155@tp.orcam.me.uk>
References: <alpine.DEB.1.10.1412100126150.19155@tp.orcam.me.uk>
	<alpine.DEB.1.10.1412100136320.19155@tp.orcam.me.uk>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 10 Dec 2014 19:41:09 +0000
Message-ID: <CAFEAcA8XC8JW-2BP47NM5pxHQmqoHC_PFbB7m2QEST4j9xETQg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/3] target-mips: Add n32/n64 configuration
	files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Leon Alrae <leon.alrae@imgtec.com>, QEMU Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On 10 December 2014 at 18:53, Maciej W. Rozycki <macro@codesourcery.com> wrote:
> Mechanically add new n32/n64 configuration files copying the relevant
> preexisting ones, fixing the system emulation configuration build, that
> breaks due to the lack of the respective configuration files, for the
> `mipsn32' and `mipsn32el' targets on this occasion as well.
>
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
>  To be applied first so as not to break the build and consequently
> bisection with the configuration changes posted next.
>
>   Maciej
>
> qemu-mips-configs.diff
> Index: qemu-git-trunk/default-configs/mipsn32-softmmu.mak
> Index: qemu-git-trunk/default-configs/mipsn32el-softmmu.mak
> Index: qemu-git-trunk/default-configs/mipsn64el-linux-user.mak
> Index: qemu-git-trunk/default-configs/mipsn64el-softmmu.mak

Some of these look weird. n32 and n64 are ABIs, right? We
shouldn't have extra -softmmu configs for different ABIs,
the guest can deal with those. The MIPS config name variants
that are only ABI related should only result in new -linux-user
binaries (where we need a binary per Linux syscall ABI).

thanks
-- PMM