From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48170)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1S0CcK-0006DN-G4
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:52:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1S0CcA-0001zj-N5
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:52:24 -0500
Received: from mail-qw0-f52.google.com ([209.85.216.52]:52661)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1S0CcA-0001ze-IO
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:52:14 -0500
Received: by qafi31 with SMTP id i31so189393qaf.4
	for <qemu-devel@nongnu.org>; Wed, 22 Feb 2012 05:52:13 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <87ty2jugiw.fsf@elfo.elfo>
References: <1329905754-11873-1-git-send-email-i.mitsyanko@samsung.com>
	<1329905754-11873-3-git-send-email-i.mitsyanko@samsung.com>
	<87ty2jugiw.fsf@elfo.elfo>
Date: Wed, 22 Feb 2012 13:52:13 +0000
Message-ID: <CAFEAcA8XEOJuOdWePOAR41mXM-VebOap+D-=MQdtKgqyvaYG-w@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 2/5] hw/pxa2xx_dma.c: drop VMSTATE_UINTTL
	usage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: balrog@zabor.org, Igor Mitsyanko <i.mitsyanko@samsung.com>, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com, afaerber@suse.de

On 22 February 2012 13:47, Juan Quintela <quintela@redhat.com> wrote:
> Igor Mitsyanko <i.mitsyanko@samsung.com> wrote:
>> Convert variables descr, src and dest from type target_phys_addr_t to uint32_t,
>> use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables.
>> We can do it safely because:
>> 1) pxa2xx has 32-bit physical address;
>> 2) rest of the code in this file treats these variables as uint32_t;
>> 3) we shouldn't have used VMSTATE_UINTTL in the first place because this macro
>> is for target_ulong type (which can be different from target_phys_addr_t).
>
> This is an incompatible change, we need to bump the version.

Why? For the cases where this device is used, target_phys_addr_t is
always 32 bits so we aren't changing anything, surely?

-- PMM