From: Peter Maydell <peter.maydell@linaro.org>
To: Hao Wu <wuhaotsh@google.com>
Cc: Patrick Venture <venture@google.com>,
Havard Skinnemoen <hskinnemoen@google.com>,
QEMU Developers <qemu-devel@nongnu.org>,
CS20 KFTing <kfting@nuvoton.com>, qemu-arm <qemu-arm@nongnu.org>,
IS20 Avi Fishman <Avi.Fishman@nuvoton.com>,
Doug Evans <dje@google.com>
Subject: Re: [PATCH 4/6] hw/arm: Add I2C device tree for Quanta GSJ
Date: Thu, 28 Jan 2021 17:33:22 +0000 [thread overview]
Message-ID: <CAFEAcA8XRQ4yG6mXVrgMdQ-65Rqn8nBV1LySOU--XLeOUaOJKQ@mail.gmail.com> (raw)
In-Reply-To: <20210126193237.1534208-5-wuhaotsh@google.com>
On Tue, 26 Jan 2021 at 19:32, Hao Wu <wuhaotsh@google.com> wrote:
>
> Add an I2C device tree for Quanta GSJ. We only included devices with
> existing QEMU implementation, including AT24 EEPROM and temperature
> sensors.
>
> Reviewed-by: Doug Evans<dje@google.com>
> Reviewed-by: Tyrong Ting<kfting@nuvoton.com>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
Same remarks as for patch 3 apply here too.
thanks
-- PMM
next prev parent reply other threads:[~2021-01-28 17:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 19:32 [PATCH 0/6] hw/i2c: Add NPCM7XX SMBus Device wuhaotsh--- via
2021-01-26 19:32 ` [PATCH 1/6] hw/arm: Remove GPIO from unimplemented NPCM7XX wuhaotsh--- via
2021-01-26 19:32 ` [PATCH 2/6] hw/i2c: Implement NPCM7XX SMBus Module Single Mode wuhaotsh--- via
2021-01-26 23:00 ` Corey Minyard
2021-01-28 17:28 ` Peter Maydell
2021-01-26 19:32 ` [PATCH 3/6] hw/arm: Add I2C device tree for NPCM750 eval board wuhaotsh--- via
2021-01-28 17:32 ` Peter Maydell
2021-01-26 19:32 ` [PATCH 4/6] hw/arm: Add I2C device tree for Quanta GSJ wuhaotsh--- via
2021-01-26 23:05 ` Corey Minyard
2021-01-28 17:33 ` Peter Maydell [this message]
2021-01-26 19:32 ` [PATCH 5/6] hw/i2c: Add a QTest for NPCM7XX SMBus Device wuhaotsh--- via
2021-01-26 19:32 ` [PATCH 6/6] hw/i2c: Implement NPCM7XX SMBus Module FIFO Mode wuhaotsh--- via
2021-01-26 23:47 ` Corey Minyard
2021-01-27 20:37 ` wuhaotsh--- via
2021-01-27 21:42 ` Corey Minyard
2021-01-27 21:59 ` wuhaotsh--- via
2021-01-27 23:37 ` Corey Minyard
2021-01-28 5:36 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8XRQ4yG6mXVrgMdQ-65Rqn8nBV1LySOU--XLeOUaOJKQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Avi.Fishman@nuvoton.com \
--cc=dje@google.com \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).