From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9954CC4332F for ; Tue, 12 Dec 2023 16:44:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rD5rQ-0003Kk-2G; Tue, 12 Dec 2023 11:43:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD5rK-0003Jz-6m for qemu-devel@nongnu.org; Tue, 12 Dec 2023 11:43:50 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rD5rI-0004d4-IQ for qemu-devel@nongnu.org; Tue, 12 Dec 2023 11:43:49 -0500 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-551d5cd1c5fso654940a12.0 for ; Tue, 12 Dec 2023 08:43:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702399426; x=1703004226; darn=nongnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=80mMrq9q6tWkSoQQCypb8VG9fAJ9L8n8T1QsxloxpqA=; b=lOFzVAeZ0OV8Wdbw+3ZnUyjhOF+WXNsyyvfpbfJiwmlVx/HlibcHLHWEROElQju6wj r6XxpBm4lqtson4yolY/Cb+7kBPO2kNrdFWnkFUv8Zm/4l41pQpHh/nQnIjzG+Ow0gwW fiJuHkxd0TeJx9TDWaLnOcoGe59noPtzbB/Tb3XRCb6xPK5rzVdRzVipzOfgwAz4IIkf tZRjQfq/r9+HpVkCzFhfpXC4yESJV2oStznJQqKDkxIFI7K05IQVXbPsTqE130/crCu2 E6ybvoYy4WGQx957eHergWGUGpM8ZRsfDHx2CYY7UuWL2wbsjGlF43LvnEadZ9G7PkTp Rv+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702399426; x=1703004226; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=80mMrq9q6tWkSoQQCypb8VG9fAJ9L8n8T1QsxloxpqA=; b=lyrA6XoXT4kvxh2fi99ZQy8XGy+osmC/bkPXqkJJZK6A5wgnf8Q0sktKE5IJKP+N91 n54NKdkWh8oYFSoKOEhUxSL/WRCZ/WXzc2vanaU2lZ2Puq9xp605iEu3lMpFIS61S4g7 dEJWG6rqEcAJUDZCVf20q+ht9ZDt0uOJo+8ikv4DfwqY++9p1e/gb9g7oJO8UKmJlnw3 0ot23xrU63Rsqh2w7EvJ2CFapV7vsQ26j47TRcCflU94gq8LtPuAVcpD3qt3lxEf2AW7 hgBLO5+d6ZGU7N3DyUMSU//ibM1VgUj2ngvBN8KzyvC3hqbeBxMr9RKPyQdLJ9Z6PCjR 11xQ== X-Gm-Message-State: AOJu0Yz/fHeVZkO0I2DSWFbJs/enpfQWe8eN5bk8ASv3FADuSgSjpRn4 Xvk8qvYdn/YtzucXtpSySmlpf4K8ALMSsG7gCXM+AQ== X-Google-Smtp-Source: AGHT+IFL0SNs/udt9ka79UgYlvT4OPMxRFdTEsoyoehQUKhoxM8x2KUsssnJFL8xVPgeflAv6bWoUt12kJIhna93/uU= X-Received: by 2002:aa7:c484:0:b0:551:e56b:6e9 with SMTP id m4-20020aa7c484000000b00551e56b06e9mr184050edq.19.1702399425960; Tue, 12 Dec 2023 08:43:45 -0800 (PST) MIME-Version: 1.0 References: <20231123143813.42632-1-philmd@linaro.org> <20231123143813.42632-3-philmd@linaro.org> In-Reply-To: <20231123143813.42632-3-philmd@linaro.org> From: Peter Maydell Date: Tue, 12 Dec 2023 16:43:35 +0000 Message-ID: Subject: Re: [PATCH-for-9.0 v2 2/8] hw/arm/bcm2836: Simplify use of 'reset-cbar' property To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Markus Armbruster , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Alistair Francis , Joel Stanley , Artyom Tarasenko , Mark Cave-Ayland , Ani Sinha , Eduardo Habkost , David Gibson , "Michael S. Tsirkin" , Andrew Jeffery , Daniel Henrique Barboza , Yoshinori Sato , "Edgar E. Iglesias" , Niek Linnenbank , Andrey Smirnov , Tyrone Ting , Jean-Christophe Dubois , Strahinja Jankovic , Harsh Prateek Bora , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Paolo Bonzini , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Aurelien Jarno , Igor Mammedov , qemu-ppc@nongnu.org, Hao Wu , Marcel Apfelbaum , Beniamino Galvani , Richard Henderson , Nicholas Piggin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 23 Nov 2023 at 14:38, Philippe Mathieu-Daud=C3=A9 wrote: > > bcm2836_realize() is called by > > - bcm2836_class_init() which sets: > > bc->cpu_type =3D ARM_CPU_TYPE_NAME("cortex-a7") > > - bcm2837_class_init() which sets: > > bc->cpu_type =3D ARM_CPU_TYPE_NAME("cortex-a53") > > Both Cortex-A7 / A53 have the ARM_FEATURE_CBAR set. If it isn't, > then this is a programming error: use &error_abort. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- Reviewed-by: Peter Maydell thanks -- PMM