From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58429)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XlJAU-000689-ON
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 10:03:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XlJAP-00026G-77
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 10:03:42 -0500
Received: from mail-lb0-f172.google.com ([209.85.217.172]:38811)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XlJAP-00025w-1M
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 10:03:37 -0500
Received: by mail-lb0-f172.google.com with SMTP id w7so2266395lbi.17
	for <qemu-devel@nongnu.org>; Mon, 03 Nov 2014 07:03:35 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1415002312-30827-1-git-send-email-syeon.hwang@samsung.com>
References: <1415002312-30827-1-git-send-email-syeon.hwang@samsung.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 3 Nov 2014 15:03:15 +0000
Message-ID: <CAFEAcA8Y7dWeniGwx6KzZr+jfOSZ2P+o2cvHSkfU2Z_8VAct6A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2] translate-all: Marked map_exec() with
	the 'unused' attribute
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: SeokYeon Hwang <syeon.hwang@samsung.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 3 November 2014 08:11, SeokYeon Hwang <syeon.hwang@samsung.com> wrote:
> Marked map_exec() with the 'unused' attribute to avoid '-Wunused-function' on clang 3.4 or later.
>
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
>  translate-all.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index ba5c840..9d150fb 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -270,14 +270,14 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr)
>  }
>
>  #ifdef _WIN32
> -static inline void map_exec(void *addr, long size)
> +static __attribute__((unused)) void map_exec(void *addr, long size)
>  {
>      DWORD old_protect;
>      VirtualProtect(addr, size,
>                     PAGE_EXECUTE_READWRITE, &old_protect);
>  }
>  #else
> -static inline void map_exec(void *addr, long size)
> +static __attribute__((unused)) void map_exec(void *addr, long size)
>  {
>      unsigned long start, end, page_size;
>
> --
> 2.1.0

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM