From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PULL 03/18] target/arm: Store FPSR cumulative exception bits in env->vfp.fpsr
Date: Thu, 31 Oct 2024 17:40:16 +0000 [thread overview]
Message-ID: <CAFEAcA8YC82WdP_cesZVM_Luf3WBdQH8dpJHrRThE-DLzaAqng@mail.gmail.com> (raw)
In-Reply-To: <1a18a816-ba21-4838-a9c0-fb8362ee5e17@tls.msk.ru>
On Thu, 31 Oct 2024 at 17:31, Michael Tokarev <mjt@tls.msk.ru> wrote:
> What I see is that the whole thing - plus one more commit right
> before the mentioned refactoring, ea8618382aba, "target/arm: Correct
> comments about M-profile FPSCR" - applies cleanly to 9.0 and 8.2.
> For 7.2 though, this is definitely too much because there, tcg code
> has different rules for the temps, - in particular, it frees all
> temps explicitly, so new code wont fit there anyway, resulting in
> leaks and requiring major re-review.
>
> Being niche, I'd not bother with that even in 8.2, but the fact
> this refactoring applies nicely.. :)
>
> It's probably the first time when the difference between many
> changes but tested in master, vs smaller possible change, is quite
> significant. I prefer for it to just work ;))
>
> 8.2 is in ubuntu noble (LTS), so it might be with us a bit longer
> than some other series, but in ubuntu they build with KVM support,
> so the bug isn't there.
Note that the bug is not in "TCG + KVM" or "TCG only"
configs, but specifically "KVM without TCG" (i.e
you configured with '--disable-tcg' on an aarch64 host).
-- PMM
next prev parent reply other threads:[~2024-10-31 17:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 15:10 [PULL 00/18] target-arm queue Peter Maydell
2024-10-29 15:10 ` [PULL 01/18] arm/kvm: add support for MTE Peter Maydell
2024-10-29 15:10 ` [PULL 02/18] docs/system/cpu-hotplug: Update example's socket-id/core-id Peter Maydell
2024-10-29 15:10 ` [PULL 03/18] target/arm: Store FPSR cumulative exception bits in env->vfp.fpsr Peter Maydell
2024-10-31 16:55 ` Michael Tokarev
2024-10-31 17:01 ` Peter Maydell
2024-10-31 17:31 ` Michael Tokarev
2024-10-31 17:40 ` Peter Maydell [this message]
2024-10-31 17:44 ` Michael Tokarev
2024-10-29 15:10 ` [PULL 04/18] target/arm: Don't assert in regime_is_user() for E10 mmuidx values Peter Maydell
2024-10-29 15:10 ` [PULL 05/18] hw/sd/omap_mmc: Don't use sd_cmd_type_t Peter Maydell
2024-10-29 15:10 ` [PULL 06/18] tests/functional: Add a functional test for the collie board Peter Maydell
2024-10-29 15:10 ` [PULL 07/18] tests/functional: Add a functional test for the sx1 board Peter Maydell
2024-10-29 15:10 ` [PULL 08/18] scripts/symlink-install-tree.py: Fix MESONINTROSPECT parsing Peter Maydell
2024-10-29 15:10 ` [PULL 09/18] docs/system/arm/stm32: List olimex-stm32-h405 in document title Peter Maydell
2024-10-29 15:10 ` [PULL 10/18] docs/system/arm: Don't use wildcard '*-bmc' in doc titles Peter Maydell
2024-10-29 15:10 ` [PULL 11/18] docs/system/arm: Split fby35 out from aspeed.rst Peter Maydell
2024-10-29 15:10 ` [PULL 12/18] docs/system/arm: Add placeholder doc for exynos4 boards Peter Maydell
2024-10-29 15:10 ` [PULL 13/18] docs/system/arm: Add placeholder doc for xlnx-zcu102 board Peter Maydell
2024-10-29 15:10 ` [PULL 14/18] docs/system/arm: Add placeholder docs for mcimx6ul-evk and mcimx7d-sabre Peter Maydell
2024-10-29 15:10 ` [PULL 15/18] docs/system/target-arm.rst: Remove "many boards are undocumented" note Peter Maydell
2024-10-29 15:10 ` [PULL 16/18] target/arm: Fix arithmetic underflow in SETM instruction Peter Maydell
2024-10-29 15:10 ` [PULL 17/18] docs/devel/reset: Fix minor grammatical error Peter Maydell
2024-10-29 15:10 ` [PULL 18/18] target/arm: kvm: require KVM_CAP_DEVICE_CTRL Peter Maydell
2024-10-31 16:33 ` [PULL 00/18] target-arm queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8YC82WdP_cesZVM_Luf3WBdQH8dpJHrRThE-DLzaAqng@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).