From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjDsA-0003yz-Al for qemu-devel@nongnu.org; Fri, 06 Jan 2012 12:46:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjDs9-00020N-Bd for qemu-devel@nongnu.org; Fri, 06 Jan 2012 12:46:34 -0500 Received: from mail-qy0-f173.google.com ([209.85.216.173]:34202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjDs9-00020G-4C for qemu-devel@nongnu.org; Fri, 06 Jan 2012 12:46:33 -0500 Received: by qcsd15 with SMTP id d15so1111929qcs.4 for ; Fri, 06 Jan 2012 09:46:32 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4F073097.8070002@calxeda.com> References: <1325793761-10249-1-git-send-email-mark.langsdorf@calxeda.com> <1325793761-10249-6-git-send-email-mark.langsdorf@calxeda.com> <4F072849.3080908@calxeda.com> <4F073097.8070002@calxeda.com> Date: Fri, 6 Jan 2012 17:46:32 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Langsdorf Cc: "qemu-devel@nongnu.org" , Rob Herring , "afaerber@suse.de" On 6 January 2012 17:34, Mark Langsdorf wrote: > On 01/06/2012 11:04 AM, Peter Maydell wrote: >> On 6 January 2012 16:58, Mark Langsdorf wro= te: >>>>> + =C2=A0 =C2=A0if (load_image_targphys("sysram.bin", 0xfff88000, 0x80= 00) < 0) { >>>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fprintf(stderr, "Unable to= load sysram.bin\n"); >>>>> + =C2=A0 =C2=A0} >> If it's not necessary, should we be failing if there isn't an image file >> present? > > Are we failing? We're printing out a warning message, but the > boot goes on. Doh. Completely misread that bit of code :-) -- PMM