qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers
Date: Thu, 6 Sep 2012 20:00:38 +0100	[thread overview]
Message-ID: <CAFEAcA8ZVZu9xQ+x+R30dZYAushNZn8runxVd-fJL9J0jheUOw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_yKecR8Wnnx2npB-XJPxer+5rf8LBnky_YHLNVJg=9Dw@mail.gmail.com>

On 4 September 2012 21:48, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 4 September 2012 21:37, Blue Swirl <blauwirbel@gmail.com> wrote:
>> Add an explicit CPUState parameter instead of relying on AREG0.
>>
>> For easier review, convert only op helpers which don't return any value.
>>
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> Thanks for splitting these up, it helped a lot.

Forgot to ask, are you planning to apply these directly?
I'm happy to take them via the target-arm tree but I imagine
there'll be merge conflicts on that line in configure if we
do that for every target...

thanks
-- PMM

  reply	other threads:[~2012-09-06 19:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 20:37 [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers Blue Swirl
2012-09-04 20:37 ` [Qemu-devel] [PATCH 2/3] target-arm: convert remaining helpers Blue Swirl
2012-09-04 20:49   ` Peter Maydell
2012-09-04 20:37 ` [Qemu-devel] [PATCH 3/3] target-arm: final conversion to AREG0 free mode Blue Swirl
2012-09-04 20:50   ` Peter Maydell
2012-09-04 20:48 ` [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers Peter Maydell
2012-09-06 19:00   ` Peter Maydell [this message]
2012-09-08  8:14     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8ZVZu9xQ+x+R30dZYAushNZn8runxVd-fJL9J0jheUOw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=blauwirbel@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).