From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: James Hogan <james.hogan@imgtec.com>,
kvm-devel <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Sanjay Lal <sanjayl@kymasys.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS
Date: Thu, 13 Mar 2014 22:35:58 +0000 [thread overview]
Message-ID: <CAFEAcA8_PL3e2ckqFa4KBxNT-R2mK5cKCEOpod3cx0cYX6PGXA@mail.gmail.com> (raw)
In-Reply-To: <53222304.3050902@suse.de>
On 13 March 2014 21:28, Andreas Färber <afaerber@suse.de> wrote:
> int32 is a type used in softfloat that has weird at-least-as-wide
> semantics and bit us in the past.
I'm coming round to the opinion that we should just change all
those to int32_t &c. I know we had a discussion about efficiency
at one point and I was on the other side at that time, but I
don't really think it matters much either way and having the
types still lurking around is just confusing. Maybe after 2.0
(and we should nuke the STATUS macros too).
Either way, int32 shouldn't be used outside the softfloat code
and its callers.
> I'm not sure if we have a policy about __u64 etc. in KVM code. Since
> it'll be Linux-only I don't see problems currently; for cross-platform
> parts we prefer uint64_t. Suggest to leave as is unless told otherwise.
For ARM I took the view that __u64 were the kernel's types, not
ours. The kernel header structs define fields as __u64 but for
in-QEMU functions and variables we should use the posix uint64_t.
thanks
-- PMM
next prev parent reply other threads:[~2014-03-13 22:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 17:09 [Qemu-devel] [PATCH v3 0/9] KVM Support for MIPS32 Processors James Hogan
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 1/9] hw/mips/cputimer: Don't start periodic timer in KVM mode James Hogan
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 2/9] hw/mips: Add API to convert KVM guest KSEG0 <-> GPA James Hogan
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 3/9] target-mips: get_physical_address: Add defines for segment bases James Hogan
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 4/9] target-mips: get_physical_address: Add KVM awareness James Hogan
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 5/9] kvm: Allow arch to set sigmask length James Hogan
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS James Hogan
2014-03-13 21:28 ` Andreas Färber
2014-03-13 22:35 ` Peter Maydell [this message]
2014-03-14 9:43 ` James Hogan
2014-03-14 12:53 ` Paolo Bonzini
2014-03-14 9:42 ` James Hogan
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 7/9] hw/mips: In KVM mode, inject IRQ2 (I/O) interupts via ioctls James Hogan
2014-03-13 21:30 ` Andreas Färber
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 8/9] hw/mips: malta: Add KVM support James Hogan
2014-03-06 17:09 ` [Qemu-devel] [PATCH v3 9/9] target-mips: Enable KVM support in build system James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8_PL3e2ckqFa4KBxNT-R2mK5cKCEOpod3cx0cYX6PGXA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=gleb@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).