From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43562)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WOEEi-0003Ro-NT
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 18:36:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WOEEd-0002zX-R6
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 18:36:24 -0400
Received: from mail-lb0-f173.google.com ([209.85.217.173]:63414)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WOEEd-0002zQ-KV
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 18:36:19 -0400
Received: by mail-lb0-f173.google.com with SMTP id p9so1183547lbv.18
	for <qemu-devel@nongnu.org>; Thu, 13 Mar 2014 15:36:18 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <53222304.3050902@suse.de>
References: <1394125778-18746-1-git-send-email-james.hogan@imgtec.com>
	<1394125778-18746-7-git-send-email-james.hogan@imgtec.com>
	<53222304.3050902@suse.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 13 Mar 2014 22:35:58 +0000
Message-ID: <CAFEAcA8_PL3e2ckqFa4KBxNT-R2mK5cKCEOpod3cx0cYX6PGXA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM
 support for MIPS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: James Hogan <james.hogan@imgtec.com>, kvm-devel <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Sanjay Lal <sanjayl@kymasys.com>, Paolo Bonzini <pbonzini@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>

On 13 March 2014 21:28, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> int32 is a type used in softfloat that has weird at-least-as-wide
> semantics and bit us in the past.

I'm coming round to the opinion that we should just change all
those to int32_t &c. I know we had a discussion about efficiency
at one point and I was on the other side at that time, but I
don't really think it matters much either way and having the
types still lurking around is just confusing. Maybe after 2.0
(and we should nuke the STATUS macros too).

Either way, int32 shouldn't be used outside the softfloat code
and its callers.

> I'm not sure if we have a policy about __u64 etc. in KVM code. Since
> it'll be Linux-only I don't see problems currently; for cross-platform
> parts we prefer uint64_t. Suggest to leave as is unless told otherwise.

For ARM I took the view that __u64 were the kernel's types, not
ours. The kernel header structs define fields as __u64 but for
in-QEMU functions and variables we should use the posix uint64_t.

thanks
-- PMM