From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH] stellaris: Don't hw_error() on bad register accesses
Date: Thu, 6 Apr 2017 17:37:28 +0100 [thread overview]
Message-ID: <CAFEAcA8a4a-dm5K63uJJCWW3W2JQOrmRKWFFfiyb0_v_G_yf5g@mail.gmail.com> (raw)
In-Reply-To: <419a5b1f-5442-0105-d5f3-e2ab08f461bd@amsat.org>
On 6 April 2017 at 17:24, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi Peter,
>
>
> On 04/06/2017 10:45 AM, Peter Maydell wrote:
>> default:
>> - hw_error("gptm_write: Bad offset 0x%x\n", (int)offset);
>> + qemu_log_mask(LOG_GUEST_ERROR,
>> + "GPTM: read at bad offset 0x%x\n", (int)offset);
>
>
> use HWADDR_PRIx to remove this unnecessary casts here in following changes?
>
> ie: "GPTM: read at bad offset 0x%" HWADDR_PRIx "\n", offset);
I don't think either of the two is clearly better for this
sort of case where the offset is known to be small, so I opted
to leave the code the way it was already written.
> either way:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Thanks.
-- PMM
prev parent reply other threads:[~2017-04-06 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 13:45 [Qemu-devel] [PATCH] stellaris: Don't hw_error() on bad register accesses Peter Maydell
2017-04-06 16:24 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-04-06 16:37 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8a4a-dm5K63uJJCWW3W2JQOrmRKWFFfiyb0_v_G_yf5g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=f4bug@amsat.org \
--cc=patches@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).