From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35429)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZYtXS-0004KB-89
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 06:20:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZYtXO-0001eR-3z
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 06:20:38 -0400
Received: from mail-vk0-f44.google.com ([209.85.213.44]:34789)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZYtXO-0001e4-0f
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 06:20:34 -0400
Received: by vkhf67 with SMTP id f67so40984539vkh.1
	for <qemu-devel@nongnu.org>; Mon, 07 Sep 2015 03:20:33 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <55ED60B3.6030903@redhat.com>
References: <1440844439-19391-1-git-send-email-crosthwaite.peter@gmail.com>
	<55ED60B3.6030903@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 7 Sep 2015 11:20:14 +0100
Message-ID: <CAFEAcA8aMnDqMbRaryeJM+qUPOCKAjdkovUvQBARwLLjzKafFg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2] configure: factor out adding disas
	configure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Crosthwaite <crosthwaitepeter@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 7 September 2015 at 11:02, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 29/08/2015 12:33, Peter Crosthwaite wrote:
>> Every arch adds its disas configury to both its own config as well
>> config_disas_all. Make a small function do to both at once.

>>  for i in $ARCH $TARGET_BASE_ARCH ; do
>>    case "$i" in
>>    alpha)
>> -    echo "CONFIG_ALPHA_DIS=y"  >> $config_target_mak
>> -    echo "CONFIG_ALPHA_DIS=y"  >> config-all-disas.mak
>> +    disas_config "ALPHA"
>>    ;;
>>    aarch64)
>>      if test -n "${cxx}"; then
>> -      echo "CONFIG_ARM_A64_DIS=y"  >> $config_target_mak
>> -      echo "CONFIG_ARM_A64_DIS=y"  >> config-all-disas.mak
>> +      disas_config "ARM_A64"
>>      fi
>>    ;;
>>    arm)
>> -    echo "CONFIG_ARM_DIS=y"  >> $config_target_mak
>> -    echo "CONFIG_ARM_DIS=y"  >> config-all-disas.mak
>> +    disas_config "ARM"
>>      if test -n "${cxx}"; then
>> -      echo "CONFIG_ARM_A64_DIS=y"  >> $config_target_mak
>> -      echo "CONFIG_ARM_A64_DIS=y"  >> config-all-disas.mak
>> +      disas_config "ARM_A64"
>
> Why both?

Because this case is on $TARGET_BASE_ARCH, so if the
target is aarch64 we only see 'arm' here. (The
'aarch64' case is used for $ARCH, which is the
aarch64-host situation.)

>>  if test "$tcg_interpreter" = "yes" ; then
>> -  echo "CONFIG_TCI_DIS=y"  >> $config_target_mak
>> -  echo "CONFIG_TCI_DIS=y"  >> config-all-disas.mak
>> +  disas_config "TCI"
>>  fi
>
> Shouldn't TCI be a config_host property?

This is just the same way we say "host disassembler
is foo" for all hosts; TCI isn't any different here.

thanks
-- PMM