From: Peter Maydell <peter.maydell@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: add missing return in netlink switch statement
Date: Tue, 14 Jun 2016 14:14:34 +0100 [thread overview]
Message-ID: <CAFEAcA8atiGbQaHQU1EVV+H72VVDCfmwkJuR__ExDANAy5fX4Q@mail.gmail.com> (raw)
In-Reply-To: <1465909629-12698-1-git-send-email-laurent@vivier.eu>
On 14 June 2016 at 14:07, Laurent Vivier <laurent@vivier.eu> wrote:
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> linux-user/syscall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 71ccbd9..0b937ca 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1688,6 +1688,7 @@ static abi_long target_to_host_for_each_nlmsg(struct nlmsghdr *nlh,
> struct nlmsgerr *e = NLMSG_DATA(nlh);
> e->error = tswap32(e->error);
> tswap_nlmsghdr(&e->msg);
> + return 0;
> }
> default:
> ret = target_to_host_nlmsg(nlh);
> --
> 2.5.5
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
prev parent reply other threads:[~2016-06-14 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 13:07 [Qemu-devel] [PATCH] linux-user: add missing return in netlink switch statement Laurent Vivier
2016-06-14 13:14 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8atiGbQaHQU1EVV+H72VVDCfmwkJuR__ExDANAy5fX4Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).