From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60609)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1c3kOu-0000Zk-2s
	for qemu-devel@nongnu.org; Mon, 07 Nov 2016 08:55:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1c3kOt-0007KT-8G
	for qemu-devel@nongnu.org; Mon, 07 Nov 2016 08:55:52 -0500
Received: from mail-vk0-x230.google.com ([2607:f8b0:400c:c05::230]:35608)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <peter.maydell@linaro.org>)
	id 1c3kOt-0007KD-3U
	for qemu-devel@nongnu.org; Mon, 07 Nov 2016 08:55:51 -0500
Received: by mail-vk0-x230.google.com with SMTP id w194so121239006vkw.2
	for <qemu-devel@nongnu.org>; Mon, 07 Nov 2016 05:55:50 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20161107133833.3681-1-msuchanek@suse.de>
References: <20161107133833.3681-1-msuchanek@suse.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 7 Nov 2016 13:55:29 +0000
Message-ID: <CAFEAcA8auW70Bpji93ujCjur3q4m3sffAtccv8S2MSzJSkydow@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michal Suchanek <msuchanek@suse.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 7 November 2016 at 13:38, Michal Suchanek <msuchanek@suse.de> wrote:
> ncurses version in SUSE does not have .pc files so this is still needed to
> build from git.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fd6f898..aab70ef 100755
> --- a/configure
> +++ b/configure
> @@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then
>      curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):"
>      curses_lib_list="$($pkg_config --libs ncurses 2>/dev/null):-lpdcurses"
>    else
> -    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
> +    curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null)-I/usr/include/ncursesw:"
>      curses_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lncursesw:-lcursesw"

I think this will produce malformed output on platforms where
pkg-config does output something useful:
-D_GNU_SOURCE -I/usr/include/ncursesw-I/usr/include/ncursesw:

because there's no colon after the ')'.

In fact this code looks kind of dubious in general, because
it seems to assume that the output of pkg_config never has
a ':' in it...

thanks
-- PMM